This is a convenience flag, which still let the user override the flags he wants. This depends on D11358 for the min stake amount to work properly. There is no change in behavior when the flag is not set.
Details
Details
- Reviewers
tyler-smith - Group Reviewers
Restricted Project - Commits
- rABC2ca0661e472a: [avalanche] Add an easy to use shortcut flag to turn on avalanche
ninja check-avalanche
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche_single_flag
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18844 Build 37478: Build Diff build-without-wallet · build-diff · lint-circular-dependencies · build-debug · build-clang · build-clang-tidy Build 37477: arc lint + arc unit
Event Timeline
Comment Actions
Everything looks correctly implemented and the logic all makes sense, except I'm not clear on the reasoning about the quorum params.
| src/init.cpp | ||
|---|---|---|
| 1758 ↗ | (On Diff #33223) | What is the logic behind settings these 2 quorum params to these hardcoded values if -avalanche is set, but the constant-based defaults if it's not set? |
| src/init.cpp | ||
|---|---|---|
| 1758 ↗ | (On Diff #33223) | This is such that if you want to change the default, the tests needs to be adapted accordingly and you are not silently ignoring the change. But you are missing the elephant in the room on the line below: if -ecash is unset, we are using a value 1000000 times too large. |