Differential D11442

Fix thread safety error: negative handling capability
ClosedPublic
Actions

Authored by Fabien on May 11 2022, 08:46.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd63cbfbcbd5b: Fix thread safety error: negative handling capability

Summary

This errors arise with some clang version and -Wthread-safety-analysis. Introduced in D11436.
Note: the annotations are also needlessely duplicated in the function definition and should be removed by backporting https://github.com/bitcoin/bitcoin/pull/21188.

Test Plan

With a recent Clang:

ninja all check

Check it raises no warning.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 11 2022, 08:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2022, 08:46

Fabien requested review of this revision.May 11 2022, 08:46

Harbormaster completed remote builds in B18993: Diff 33470.May 11 2022, 09:02

PiRK accepted this revision.May 11 2022, 09:35

This revision is now accepted and ready to land.May 11 2022, 09:35

Closed by commit rABCd63cbfbcbd5b: Fix thread safety error: negative handling capability (authored by Fabien). · Explain WhyMay 11 2022, 11:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd63cbfbcbd5b: Fix thread safety error: negative handling capability.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

3 lines

Diff 33475

src/net_processing.cpp

Loading...