Differential D11459

Stop parsing the radix tree if the callback function returns false
ClosedPublic
Actions

Authored by Fabien on May 13 2022, 14:22.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1e89fde33b27: Stop parsing the radix tree if the callback function returns false

Summary

This diff lets the callsite decide to continue or stop the tree traversal at each leaf. Returning true continue the loop, and returning false stops it.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

radix_tree_parse_early_exit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19019
Build 37794: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 37793: arc lint + arc unit

Event Timeline

Fabien created this revision.May 13 2022, 14:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2022, 14:22

Fabien requested review of this revision.May 13 2022, 14:22

Fabien planned changes to this revision.May 13 2022, 14:30

Also return the completion status to the callsite

Harbormaster completed remote builds in B19018: Diff 33504.May 13 2022, 14:37

Harbormaster completed remote builds in B19019: Diff 33505.May 13 2022, 14:43

This is good, I left a few comments on ways the code could be improved upon.

src/radix.h
258	This is getting fairly nested, you should probably swap the conditions around.
262	I find the ternary here to be quite confusing.

This revision is now accepted and ready to land.May 13 2022, 20:46

Revert the ternary, and invert the conditions to gain 1 level of nesting

Harbormaster completed remote builds in B19022: Diff 33509.May 13 2022, 23:20

Closed by commit rABC1e89fde33b27: Stop parsing the radix tree if the callback function returns false (authored by Fabien). · Explain WhyMay 13 2022, 23:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1e89fde33b27: Stop parsing the radix tree if the callback function returns false.

Revision Contents
Changeset List

Path

Size

src/

22 lines

test/

radix_tests.cpp

19 lines

Diff 33505

src/radix.h

Loading...

src/test/radix_tests.cpp

Loading...