[avalanche] Simplify proof deserialization in the RPC
AbandonedPublic
Actions

Authored by Fabien on May 13 2022, 22:57.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

In preparation for changing the underlying type of ProofRef, this diff deserializes the ProofRef from a single function. This makes less duplication and will make it simpler to update the retuned type in the future. There is no change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_verify_return_proof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19021
Build 37798: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-clang-tidy · build-clang · build-diff
Build 37797: arc lint + arc unit

Event Timeline

Fabien created this revision.May 13 2022, 22:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2022, 22:57

Fabien requested review of this revision.May 13 2022, 22:57

Harbormaster completed remote builds in B19021: Diff 33508.May 13 2022, 23:12

I don't think this patch helps with anything.

src/rpc/avalanche.cpp
78	This bakes the type of smart pointer used when it wasn't before. I don't think this makes sense.
986	This allocates the proof on the heap when it wasn't before.

This revision now requires changes to proceed.May 13 2022, 23:31

Fabien abandoned this revision.May 14 2022, 01:58

Revision Contents
Changeset List

Path

Size

src/

rpc/

avalanche.cpp

16 lines

Diff 33508

View Options

[avalanche] Simplify proof deserialization in the RPCAbandonedPublicActions