Differential D11525

[Cashtab] Hide Add To Contacts option if sender is a contact
ClosedPublic
Actions

Authored by kieran709 on May 27 2022, 16:51.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb9a58952f19f: [Cashtab] Hide Add To Contacts option if sender is a contact

Summary

Related to T2412. Added conditional logic to hide the Add To Contact option in TxHistory if the sender is already a contact.

Test Plan

cd web/cashtab && npm start
From TxHistory:
Click on a received Tx from a wallet that is not a contact and add the contact
Refresh the page and navigate back to TxHistory
Observe that the Add to Contacts option no longer appears for Txs received from the contact

Diff Detail

Repository

rABC Bitcoin ABC

Branch

hide-add-contact-if-contact

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19163
Build 38074: Build Diff	cashtab-tests
Build 38073: arc lint + arc unit

Event Timeline

kieran709 created this revision.May 27 2022, 16:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2022, 16:51

kieran709 requested review of this revision.May 27 2022, 16:51

Harbormaster completed remote builds in B19163: Diff 33705.May 27 2022, 16:54

Ideal size for a diff. One change, easy to follow & test.

This revision is now accepted and ready to land.May 27 2022, 22:14

Closed by commit rABCb9a58952f19f: [Cashtab] Hide Add To Contacts option if sender is a contact (authored by kieran709). · Explain WhyMay 31 2022, 15:49

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCb9a58952f19f: [Cashtab] Hide Add To Contacts option if sender is a contact.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Home/

48 lines

Diff 33705

web/cashtab/src/components/Home/Tx.js

Loading...