Page MenuHomePhabricator

[Casthab] Remove classNames from Tx.js
ClosedPublic

Authored by kieran709 on May 27 2022, 17:02.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCa27c3bf49dc1: [Casthab] Remove classNames from Tx.js
Summary

Replaced components with classnames with styled-components, removed unecessary 'antd-collapse' className. Related to T2445.

Test Plan

cd web/cashtab && npm start
Ensure there is at least one received eCash tx, eToken tx and genesis tx.
check that the Tx amount for each is the appropriate color

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-classNames-from-tx-component
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19164
Build 38076: Build Diffcashtab-tests
Build 38075: arc lint + arc unit

Event Timeline

bytesofman added inline comments.
web/cashtab/src/components/Home/Tx.js
366

Is this not getting any styling?

Removing this className should be in its own diff. Limit this diff to removing the genesis and received classNames

This revision now requires changes to proceed.May 27 2022, 22:18

Re-added className to AntdContextCollapseWrapper

This revision is now accepted and ready to land.May 31 2022, 17:34
This revision was automatically updated to reflect the committed changes.