Differential D11526

[Casthab] Remove classNames from Tx.js
ClosedPublic
Actions

Authored by kieran709 on May 27 2022, 17:02.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCa27c3bf49dc1: [Casthab] Remove classNames from Tx.js

Summary

Replaced components with classnames with styled-components, removed unecessary 'antd-collapse' className. Related to T2445.

Test Plan

cd web/cashtab && npm start
Ensure there is at least one received eCash tx, eToken tx and genesis tx.
check that the Tx amount for each is the appropriate color

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove-classNames-from-tx-component

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19204
Build 38156: Build Diff	cashtab-tests
Build 38155: arc lint + arc unit

Event Timeline

kieran709 created this revision.May 27 2022, 17:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2022, 17:02

kieran709 requested review of this revision.May 27 2022, 17:02

Harbormaster completed remote builds in B19164: Diff 33706.May 27 2022, 17:05

bytesofman requested changes to this revision.May 27 2022, 22:18

bytesofman added inline comments.

web/cashtab/src/components/Home/Tx.js
366 ↗	(On Diff #33706)	Is this not getting any styling? Removing this className should be in its own diff. Limit this diff to removing the genesis and received classNames