Paths

Table of Contentst

Differential D11598

index: Add Coinstats index
ClosedPublic
Actions

Authored by PiRK on Jun 9 2022, 16:01.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC9239362cf12d: index: Add Coinstats index

Summary

Main commit
https://github.com/bitcoin/bitcoin/pull/19521/commits/dd58a4de21469d6d848ae309edc47f558628221d

index: Add Coinstats index

The index holds the values previously calculated in coinstats.cpp for each block, representing the state of the UTXO set at each height.

https://github.com/bitcoin/bitcoin/pull/19521/commits/57a026c30fef3138bb8db46e6865acb9dc2674f8

test: Add unit test for Coinstats index

https://github.com/bitcoin/bitcoin/pull/22047/commits/8ea8c927ac05980d6a81252e40b7444e9abb74f9

index: Avoid unnecessary type casts in coinstatsindex

Replace two database writes with a single atomic batch write, to avoid a risk of database corruption. See the corresponding review.

https://github.com/bitcoin/bitcoin/pull/22047/commits/1e3842385b8c0d15086c7cd8736f8c67e6c0c285

index: Use batch writing in coinstatsindex WriteBlock

This is a backport of core#19521 [4 & 8/17] and core#22047 [1 & 3/3]

Depends on D11597

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19340
Build 38417: Build Diff	lint-circular-dependencies · build-debug · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 38416: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 9 2022, 16:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2022, 16:01

PiRK requested review of this revision.Jun 9 2022, 16:01

teamcity edited the summary of this revision. (Show Details)Jun 9 2022, 16:01

PiRK edited the summary of this revision. (Show Details)Jun 9 2022, 16:01

PiRK added a parent revision: D11597: refactor: Simplify ApplyStats and ApplyHash.

PiRK added a child revision: D11599: index: Coinstats index can be activated with command line flag.Jun 9 2022, 16:10

Harbormaster completed remote builds in B19328: Diff 33927.Jun 9 2022, 16:35

squash with follow-up https://github.com/bitcoin/bitcoin/pull/22047/commits/8ea8c927ac05980d6a81252e40b7444e9abb74f9

Harbormaster completed remote builds in B19338: Diff 33945.Jun 10 2022, 09:02

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_abandonconflict.py                              | ✓ Passed  | 14 s
[0m[0;32mwallet_address_types.py                                | ✓ Passed  | 12 s
[0m[0;32mwallet_address_types.py --descriptors                  | ✓ Passed  | 8 s
[0m[0;32mwallet_avoidreuse.py                                   | ✓ Passed  | 4 s
[0m[0;32mwallet_avoidreuse.py --descriptors                     | ✓ Passed  | 4 s
[0m[0;32mwallet_backup.py                                       | ✓ Passed  | 22 s
[0m[0;32mwallet_balance.py                                      | ✓ Passed  | 24 s
[0m[0;32mwallet_balance.py --descriptors                        | ✓ Passed  | 11 s
[0m[0;32mwallet_basic.py                                        | ✓ Passed  | 19 s
[0m[0;32mwallet_coinbase_category.py                            | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                                    | ✓ Passed  | 6 s
[0m[0;32mwallet_createwallet.py                                 | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --descriptors                   | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli                        | ✓ Passed  | 3 s
[0m[0;32mwallet_descriptor.py                                   | ✓ Passed  | 6 s
[0m[0;32mwallet_disable.py                                      | ✓ Passed  | 0 s
[0m[0;32mwallet_dump.py                                         | ✓ Passed  | 4 s
[0m[0;32mwallet_encryption.py                                   | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py --descriptors                     | ✓ Passed  | 5 s
[0m[0;32mwallet_hd.py                                           | ✓ Passed  | 6 s
[0m[0;32mwallet_hd.py --descriptors                             | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                                | ✓ Passed  | 5 s
[0m[0;32mwallet_import_with_label.py                            | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py                            | ✓ Passed  | 6 s
[0m[0;32mwallet_importmulti.py                                  | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py                            | ✓ Passed  | 2 s
[0m[0;32mwallet_importprunedfunds.py --descriptors              | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                                      | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                                | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool_topup.py --descriptors                  | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                                       | ✓ Passed  | 1 s
[0m[0;32mwallet_labels.py --descriptors                         | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                               | ✓ Passed  | 9 s
[0m[0;32mwallet_listsinceblock.py                               | ✓ Passed  | 5 s
[0m[0;32mwallet_listsinceblock.py --descriptors                 | ✓ Passed  | 6 s
[0m[0;32mwallet_listtransactions.py                             | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py --descriptors               | ✓ Passed  | 3 s
[0m[0;32mwallet_multiwallet.py                                  | ✓ Passed  | 39 s
[0m[0;32mwallet_multiwallet.py --usecli                         | ✓ Passed  | 10 s
[0m[0;32mwallet_reorgsrestore.py                                | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py                     | ✓ Passed  | 3 s
[0m[0;32mwallet_send.py                                         | ✓ Passed  | 6 s
[0m[0;32mwallet_startup.py                                      | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                                    | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock                        | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                              | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py --mineblock                  | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                                    | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli                           | ✓ Passed  | 1 s
[0m[1m
ALL                                                    | ✓ Passed  | 1179 s (accumulated) 
[0mRuntime: 244 s

----------------------------------------------------------------------
Ran 10 tests in 0.093s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

PiRK planned changes to this revision.Jun 10 2022, 09:09

also squash with https://github.com/bitcoin/bitcoin/pull/22047/commits/1e3842385b8c0d15086c7cd8736f8c67e6c0c285

Harbormaster completed remote builds in B19340: Diff 33947.Jun 10 2022, 09:30

This diff is quite large. Please include a short rationale for why each backported commit was squashed into this one patch. That will help reviewers be more confident that it is complete.

This revision now requires changes to proceed.Jun 10 2022, 17:21

PiRK edited the summary of this revision. (Show Details)Jun 11 2022, 11:54

PiRK edited the summary of this revision. (Show Details)Jun 11 2022, 12:02

I added comments and the commit messages for each commit to the summary.

The unit test commit and file can be reviewed independently.

The main file has a main commit, a commit with a minor code improvement (avoid an unneccessary cast) and a commit that fixes a potential race in a database write operation.

sdulfari accepted this revision.Jun 13 2022, 18:16

This revision is now accepted and ready to land.Jun 13 2022, 18:16

Closed by commit rABC9239362cf12d: index: Add Coinstats index (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyJun 13 2022, 18:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9239362cf12d: index: Add Coinstats index.