Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCfab6ec9148cd: index: Coinstats index can be activated with command line flag

Summary

This is a backport of core#19521 [5/17]
https://github.com/bitcoin/bitcoin/pull/19521/commits/3c914d58ff323255b32e717d0ce28209ec0abdaa
partial https://github.com/bitcoin/bitcoin/pull/19521/commits/6a4c0c09ab4d073a26c3c4a02783d5dcd88f6eef

The functional test only checks that "-coinstatsindex" argument does not break anything. The rest of the functional test from commit 6a4c0c09ab is not yet applicable and will be added in the next commit.

This includes also minor documentation fixups from core#21818

Depends on D11598 and D11595

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 9 2022, 16:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2022, 16:10

PiRK requested review of this revision.Jun 9 2022, 16:10

teamcity edited the summary of this revision. (Show Details)Jun 9 2022, 16:11

PiRK added a child revision: D11600: rpc: gettxoutsetinfo can be requested for specific blockheights.Jun 9 2022, 16:15

PiRK edited the summary of this revision. (Show Details)Jun 9 2022, 16:16

PiRK added a parent revision: D11595: Bump version to 0.25.8.

Harbormaster completed remote builds in B19329: Diff 33928.Jun 9 2022, 16:31

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[340/518] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[341/518] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[342/518] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[343/518] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[344/518] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[345/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[346/518] Linking C static library src/secp256k1/libsecp256k1.a
[347/518] Linking CXX static library src/libbitcoinconsensus.a
[348/518] Linking CXX static library src/libscript.a
[349/518] Linking C executable src/secp256k1/ecmult-bench
[350/518] Linking C executable src/secp256k1/internal-bench
[351/518] Linking C executable src/secp256k1/sign-bench
[352/518] Linking C executable src/secp256k1/verify-bench
[353/518] Linking C executable src/secp256k1/recover-bench
[354/518] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[355/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[356/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[357/518] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[358/518] Linking CXX static library src/libcommon.a
[359/518] Linking CXX shared library src/libbitcoinconsensus.so.0.25.8
[360/518] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[361/518] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[362/518] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[363/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[364/518] Linking CXX executable src/bitcoin-cli
[365/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[366/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[367/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[368/518] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[369/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[370/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[371/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[372/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[373/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[374/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[375/518] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[376/518] Linking CXX executable src/bitcoin-tx
[377/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[378/518] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[379/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[380/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[381/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[382/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[383/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[384/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[385/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[386/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[387/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[388/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[389/518] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[390/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[391/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[392/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[393/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[394/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[395/518] Linking CXX static library src/wallet/libwallet.a
[396/518] Linking CXX static library src/wallet/libwallet-tool.a
[397/518] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

fix clang-tidy missing braces warning

Harbormaster completed remote builds in B19341: Diff 33948.Jun 10 2022, 09:34