Page MenuHomePhabricator
Differential D11618

[avalanche] Improve the avalanche quorum functional test
ClosedPublic
Actions

Authored by Fabien on Jun 13 2022, 12:11.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC23e672bf11ad: [avalanche] Improve the avalanche quorum functional test
Summary

This makes the purpose of the test more explicit by starting 2 nodes with different parameters and check they behave differently according the their parameters.
The latch test is removed because it does not work with more peers and is already covered in the unit tests.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_quorum

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_qorum_test_improve
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19379
Build 38494: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 38493: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 13 2022, 12:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2022, 12:11
Fabien requested review of this revision.Jun 13 2022, 12:11
Harbormaster completed remote builds in B19376: Diff 33991.Jun 13 2022, 12:37
Fabien planned changes to this revision.Jun 13 2022, 12:53
Fabien updated this revision to Diff 33992.Jun 13 2022, 12:55

Fix typo

Fabien updated this revision to Diff 33993.Jun 13 2022, 13:08

Remove useless latch test

Fabien edited the summary of this revision. (Show Details)Jun 13 2022, 13:09
Fabien updated this revision to Diff 33994.Jun 13 2022, 13:10

And the reconnect

Harbormaster completed remote builds in B19377: Diff 33992.Jun 13 2022, 13:11
Harbormaster completed remote builds in B19378: Diff 33993.Jun 13 2022, 13:24
Harbormaster completed remote builds in B19379: Diff 33994.Jun 13 2022, 13:27
Fabien added a child revision: D11619: [avalanche] Integrate the IBD check into the quorum check.Jun 13 2022, 13:31
sdulfari accepted this revision.Jun 13 2022, 18:37
This revision is now accepted and ready to land.Jun 13 2022, 18:37
Closed by commit rABC23e672bf11ad: [avalanche] Improve the avalanche quorum functional test (authored by Fabien). · Explain WhyJun 13 2022, 19:04
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC23e672bf11ad: [avalanche] Improve the avalanche quorum functional test.

Revision Contents
Changeset List

PathSize
test/
functional/
121 lines

Diff 33994

View Options

test/functional/abc_p2p_avalanche_quorum.py

Loading...