The avalanche getavaaddr functional test has been flaky on CI. It appears that in some of the avalanche tests, the p2p_lock is not held properly which is a possible cause of this flakiness. The lock is required for accessing the last_message and message_count attributes of the peer object, so it requires either to lock p2p_lock or to use the P2PInterface.wait_until() method which does it already.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC7ac695a02688: [avalanche] Make proper use of p2p_lock in avalanche tests
./test/functional/test_runner.py abc_p2p_getavaaddr abc_p2p_compactproofs
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche_fix_lock_getavaaddr
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19436 Build 38605: Build Diff build-without-wallet · build-debug · build-clang · build-clang-tidy · build-diff Build 38604: arc lint + arc unit