Page MenuHomePhabricator

[Chronik] Remove `dead_code`, `elided_lifetimes_in_paths` and `single_use_lifetimes` lints
ClosedPublic

Authored by tobias_ruck on Jul 8 2022, 12:37.

Details

Summary
  • dead_code is already contained in unused (see https://doc.rust-lang.org/rustc/lints/groups.html), so we can remove it.
  • elided_lifetimes_in_paths is already contained in rust_2018_idioms.
  • single_use_lifetimes makes it very hard to use Higher-Rank Trait Bounds (i.e. for<'a> SomeTrait<'a>), so it seems to be very noisy.
Test Plan

ninja check-bitcoinsuite

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19602
Build 38923: Build Diffbuild-chronik
Build 38922: arc lint + arc unit