Page MenuHomePhabricator

[avalanche] Fix flaky checks after orphaning a valid proof
ClosedPublic

Authored by sdulfari on Jul 8 2022, 18:30.

Details

Summary

This test occasionally fails when UpdatedBlockTip has been queued but not yet called, resulting in the proof still returning as not orphaned during the getrawavalancheproof call.

Test Plan
for i in {1..20} ; do ./test/functional/test_runner.py abc_rpc_avalancheproof.py ; done

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-flaky-rpc-avaproof
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19614
Build 38947: Build Diffbuild-clang-tidy · build-diff · build-debug · build-without-wallet · build-clang
Build 38946: arc lint + arc unit

Event Timeline

sdulfari requested review of this revision.Jul 8 2022, 18:30
This revision is now accepted and ready to land.Jul 11 2022, 06:56
Fabien requested changes to this revision.Jul 11 2022, 07:21
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc_rpc_avalancheproof.py
492 ↗(On Diff #34319)

I think you want to use node.syncwithvalidationinterfacequeue()

This revision now requires changes to proceed.Jul 11 2022, 07:21
This revision is now accepted and ready to land.Jul 11 2022, 18:51