Page MenuHomePhabricator

[avalanche] Improve RPC fields names and description in getavalanchepeerinfo
ClosedPublic

Authored by Fabien on Jul 15 2022, 16:29.

Details

Summary

The nodes field can be expected to be the node count but is the list of nodes, so let's call it node_list to remove confusion. Also the peerid has a different meaning than the peer id from the network log (e.g. nodeid), so let's clarify by renaming it avalanche_peerid and improve the help text a bit. There is no change in behavior.
No deprecation cycle is used because this is still an experimental feature.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_getavalanchepeerinfo_naming
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19651
Build 39021: Build Difflint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-diff · build-clang
Build 39020: arc lint + arc unit