Page MenuHomePhabricator
Differential D11800

[avalanche] Verify that polling has started on an item before verifying that it has stopped
ClosedPublic
Actions

Authored by sdulfari on Jul 25 2022, 23:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc3de9a21195e: [avalanche] Verify that polling has started on an item before verifying that it…
Summary

If the node registers the proof too slowly, it's possible for the stale check to complete
all 5 retries before polling has even started. This is rarity, but may be one of the root
causes of flakiness that we're seeing on CI.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_proof_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
apv-flaky-stall-check-start
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19729
Build 39177: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 39176: arc lint + arc unit

Event Timeline

sdulfari created this revision.Jul 25 2022, 23:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2022, 23:54
sdulfari requested review of this revision.Jul 25 2022, 23:54
Harbormaster completed remote builds in B19720: Diff 34511.Jul 26 2022, 00:10
Fabien requested changes to this revision.Jul 26 2022, 09:24
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc_p2p_avalanche_proof_voting.py
252 ↗(On Diff #34511)

Please apply the same fix here as the same issue might occur

This revision now requires changes to proceed.Jul 26 2022, 09:24
sdulfari requested review of this revision.Jul 26 2022, 14:41
sdulfari added inline comments.
test/functional/abc_p2p_avalanche_proof_voting.py
252 ↗(On Diff #34511)

This doesn't have the same issue because the test already waits until the proof is accepted before getting here.

Fabien requested changes to this revision.Jul 26 2022, 14:56
Fabien added inline comments.
test/functional/abc_p2p_avalanche_proof_voting.py
252 ↗(On Diff #34511)

You're right, and also via the above send_and_check_for_polling which can be leverage for the other case (see suggested diff)

465–470 ↗(On Diff #34511)
This revision now requires changes to proceed.Jul 26 2022, 14:56
sdulfari updated this revision to Diff 34522.Jul 26 2022, 19:14

Reuse code per feedback

Harbormaster completed remote builds in B19729: Diff 34522.Jul 26 2022, 19:32
Fabien accepted this revision.Jul 27 2022, 07:47
This revision is now accepted and ready to land.Jul 27 2022, 07:47
Fabien added a child revision: D11808: [avalanche] Fix flakiness in the stale vote functional test.Jul 27 2022, 08:05
Closed by commit rABCc3de9a21195e: [avalanche] Verify that polling has started on an item before verifying that it… (authored by sdulfari). · Explain WhyJul 27 2022, 17:45
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABCc3de9a21195e: [avalanche] Verify that polling has started on an item before verifying that it….

Revision Contents
Changeset List

PathSize
test/
functional/
3 lines

Diff 34522

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...