Paths

Table of Contentst

Differential D11829

[avalanche] Remove the network bypass flag, make it default for avalanche outbounds
ClosedPublic
Actions

Authored by Fabien on Aug 4 2022, 20:39.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd1eb6034187d: [avalanche] Remove the network bypass flag, make it default for avalanche…

Summary

This diff removes the -bypassnetgrouplimit flag in favor of a permanent bypass for the avalanche outbounds. It also fixes a couple issues that are preventing connecting non avalanche outbounds after we connected enough avalanche peers:

The outbound type counters have fallthrough path that cause the non avalanche outbound count to be wrong.
The group limit should still apply to non avalanche peers in the fallback case, when we couldn't find an avalanche peer.

Depends on D11833.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_remove_bypass_net_limit_flag

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19779
Build 39272: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39271: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 4 2022, 20:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2022, 20:39

Fabien requested review of this revision.Aug 4 2022, 20:39

Harbormaster completed remote builds in B19775: Diff 34589.Aug 4 2022, 20:56

Update formatting as per D11828

Harbormaster completed remote builds in B19779: Diff 34593.Aug 5 2022, 09:08

sdulfari requested changes to this revision.Aug 6 2022, 08:25

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

src/net.cpp
2554	This needs a test case

This revision now requires changes to proceed.Aug 6 2022, 08:25

Fabien requested review of this revision.Aug 6 2022, 12:02

Fabien added inline comments.

src/net.cpp
2554	That's the last case in the test below: `// Group limit still applies to non avalanche outbounds`.

Rebase on top of D11833.

Fabien edited the summary of this revision. (Show Details)Aug 8 2022, 09:41

Fabien added a parent revision: D11833: Fix a race in the net tests.

Fabien removed a parent revision: D11828: Add unit test for the outbound connection logic.

Harbormaster completed remote builds in B19785: Diff 34602.Aug 8 2022, 09:59

sdulfari added inline comments.Aug 8 2022, 15:34

src/net.cpp
2554	I mean specifically this part of the check: `nOutboundFullRelay >= m_max_outbound_full_relay` since you are modifying the behavior here.

Expand the test case to cover the change

sdulfari accepted this revision.Aug 8 2022, 15:55

This revision is now accepted and ready to land.Aug 8 2022, 15:55

Harbormaster completed remote builds in B19787: Diff 34604.Aug 8 2022, 16:08

Closed by commit rABCd1eb6034187d: [avalanche] Remove the network bypass flag, make it default for avalanche… (authored by Fabien). · Explain WhyAug 8 2022, 16:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd1eb6034187d: [avalanche] Remove the network bypass flag, make it default for avalanche….

Revision Contents
Changeset List

Path

Size

src/

22 lines

test/

33 lines

test/

lint/

1 line

Diff 34593

src/net.cpp

Loading...

src/test/net_tests.cpp

Loading...

test/lint/check-doc.py

Loading...