Paths

Table of Contentst

Differential D11845

[Cashtab] [p3 normalizeBalance fix] Add unit tests
ClosedPublic
Actions

Authored by bytesofman on Aug 11 2022, 23:47.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC3dc92c1711e5: [Cashtab] [p3 normalizeBalance fix] Add unit tests

Summary

T2601

Part 3 in a series of diffs to improve calculation of wallet balance from utxo set

Depends on D11844

Add unit tests for the normalizeBalance function.

Note: One mock had legacy balances in BCHA units and was updated to XEC.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-normalizeBalance

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19803
Build 39320: Build Diff	cashtab-tests
Build 39319: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 11 2022, 23:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 11 2022, 23:47

bytesofman requested review of this revision.Aug 11 2022, 23:47

Harbormaster completed remote builds in B19803: Diff 34627.Aug 11 2022, 23:50

bytesofman added a child revision: D11846: [Cashtab] [p4 normalizeBalance fix] Change function input to nonSlpUtxos.Aug 11 2022, 23:51

emack accepted this revision.Aug 12 2022, 05:21

This revision is now accepted and ready to land.Aug 12 2022, 05:21

Closed by commit rABC3dc92c1711e5: [Cashtab] [p3 normalizeBalance fix] Add unit tests (authored by bytesofman). · Explain WhyAug 12 2022, 15:49

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC3dc92c1711e5: [Cashtab] [p3 normalizeBalance fix] Add unit tests.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

__mocks__/

mockStoredWallets.js

4 lines

__tests__/

cashMethods.test.js

11 lines

Diff 34627

View Options

web/cashtab/src/utils/mocks/mockStoredWallets.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

[Cashtab] [p3 normalizeBalance fix] Add unit testsClosedPublicActions