[Chronik] Fix `CARGO_BUILD_DIR`, incorrectly based on CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR
ClosedPublic
Actions

Authored by tobias_ruck on Aug 16 2022, 12:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3423895bebb5: [Chronik] Fix `CARGO_BUILD_DIR`, incorrectly based on CMAKE_CURRENT_BINARY_DIR…

Summary

CARGO_BUILD_DIR is the path where the cxx crate generates the bridging sources.
We've incorrectly used CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR, and this fixes it.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-fix-cargo_build_dir

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19830
Build 39374: Build Diff	build-chronik
Build 39373: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Aug 16 2022, 12:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 16 2022, 12:57

tobias_ruck requested review of this revision.Aug 16 2022, 12:57

Harbormaster completed remote builds in B19830: Diff 34667.Aug 16 2022, 13:10

tobias_ruck added a child revision: D11863: [Chronik] Add minimal Rust <-> C++ bridge.Aug 16 2022, 13:37

Fabien accepted this revision.Sep 1 2022, 16:39

This revision is now accepted and ready to land.Sep 1 2022, 16:39

Closed by commit rABC3423895bebb5: [Chronik] Fix `CARGO_BUILD_DIR`, incorrectly based on CMAKE_CURRENT_BINARY_DIR… (authored by tobias_ruck). · Explain WhySep 1 2022, 20:30

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC3423895bebb5: [Chronik] Fix `CARGO_BUILD_DIR`, incorrectly based on CMAKE_CURRENT_BINARY_DIR….

Revision Contents
Changeset List

Path

Size

chronik/

CMakeLists.txt

2 lines

Diff 34667

View Options

[Chronik] Fix `CARGO_BUILD_DIR`, incorrectly based on CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIRClosedPublicActions