[Cashtab] Patch overflow from error string in send one to many input
ClosedPublic
Actions

Authored by kieran709 on Aug 18 2022, 16:28.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0f02ef185f3c: [Cashtab] Patch overflow from error string in send one to many input

Summary

related to T2610. When inputting an incorrect eCash address in the DestinationAddressMulti input, a long string caused the error message to extend beyond the boundaries of the app. Container div added to avoid this issue.

Test Plan

cd web/cashtab && npm start
navigate to send screen
in the advanced dropdown, toggle the multiple recipients switch
input a long string that is not a valid XEC address
observe that the error message does not extend beyond the boundary of the app

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch-error-overflow-one-to-many

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19858
Build 39430: Build Diff	cashtab-tests
Build 39429: arc lint + arc unit

Event Timeline

kieran709 created this revision.Aug 18 2022, 16:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 18 2022, 16:28

kieran709 requested review of this revision.Aug 18 2022, 16:28

Harbormaster completed remote builds in B19853: Diff 34708.Aug 18 2022, 16:31

bytesofman requested changes to this revision.Aug 18 2022, 21:11

bytesofman added inline comments.

web/cashtab/src/components/Send/Send.js
941 ↗	(On Diff #34708)	Is there a reason this fix could not be implemented by modifying the existing `<DestinationAddressMulti>` component? Preference is to modify existing component and not use a wrapper. Wrapper is acceptable if `className` is required to patch on `<DestinationAddressMulti>`

This revision now requires changes to proceed.Aug 18 2022, 21:11

kieran709 added inline comments.Aug 18 2022, 22:07

web/cashtab/src/components/Send/Send.js
941 ↗	(On Diff #34708)	I didn't think I could which was why I initially used the container div, however on closer inspection there was actually a typo in EnhancedInputs.js which was making it impossible to implement the changes from there. Pushing now with the typo fixed to show that it works, but if fixing the typo requires its own diff I can certainly make a task/diff for that.