Related to T2615. If the user inputs an invalid XEC address in the DestinationAddressMulti input, the error message should not include the amount param if it is undefined.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC704ac34685c8: [Cashtab] Hide amount in error msg if it is undefined DestinationAddressMulti
cd web/cashtab && npm start
navigate to Send screen
Under the advanced tab, toggle the Multiple Recipients toggle
Input an invalid XEC address
observe that the error message does not read 'undefined' following the comma if the value is undefined
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- hide-amount-if-amount-is-undefined-DestinationAddressMulti
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19871 Build 39456: Build Diff cashtab-tests Build 39455: arc lint + arc unit
Event Timeline
| web/cashtab/src/components/Send/Send.js | ||
|---|---|---|
| 574 ↗ | (On Diff #34719) | We also don't want to display the comma after ${addressString} in this case, e.g.  Move the comma into the conditionally rendered area |
| web/cashtab/src/components/Send/Send.js | ||
|---|---|---|
| 575 ↗ | (On Diff #34729) | Use `` instead of string addition, i.e. valueString !== undefined ? `, ${valueString}` : '' |