[Cashtab] Hide amount in error msg if it is undefined DestinationAddressMulti
ClosedPublic
Actions

Authored by kieran709 on Aug 19 2022, 16:55.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC704ac34685c8: [Cashtab] Hide amount in error msg if it is undefined DestinationAddressMulti

Summary

Related to T2615. If the user inputs an invalid XEC address in the DestinationAddressMulti input, the error message should not include the amount param if it is undefined.

Test Plan

cd web/cashtab && npm start
navigate to Send screen
Under the advanced tab, toggle the Multiple Recipients toggle
Input an invalid XEC address
observe that the error message does not read 'undefined' following the comma if the value is undefined

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Aug 19 2022, 16:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2022, 16:55

kieran709 requested review of this revision.Aug 19 2022, 16:55

kieran709 mentioned this in D11874: [Cashtab] Patch overflow from error string in send one to many input.Aug 19 2022, 16:57

Harbormaster completed remote builds in B19862: Diff 34719.Aug 19 2022, 17:00

bytesofman requested changes to this revision.Aug 22 2022, 22:37

bytesofman added inline comments.

web/cashtab/src/components/Send/Send.js
574 ↗	(On Diff #34719)	We also don't want to display the comma after `${addressString}` in this case, e.g. Move the comma into the conditionally rendered area