The latest flake8 version expects the keywords to have no parenthesis (e.g. assert foo vs assert(foo) or a space (e.g. assert (foo)) if needed.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCc1a376159d18: [linter] Make flake8 version >= 5 happy
With flake8 version 5.0.0:
arc lint --everything ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- linter_flake8_v5
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19923 Build 39552: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 39551: arc lint + arc unit
Event Timeline
Comment Actions
LGTM, with maybe one nit
| test/functional/p2p_getaddr_caching.py | ||
|---|---|---|
| 84 | This is the one case where assert (...) would be slightly better, as the parentheses would allow splitting the following statement over multiple lines and not cause autopep8 to introduce its awkward auto-formatting. | |