Page MenuHomePhabricator

[avalanche] Fix potential wrong error message in the sendavalancheproof RPC
ClosedPublic

Authored by Fabien on Sep 9 2022, 08:56.

Details

Summary

The RPC does a lot of checks before attempting to register a proof and assumes it can only fail due to conflicts. This is no longer true since previously evicted dangling proofs are rejected.
This diff makes the error message more generic so the correct error message is returned, and new errors will be printed correctly as well.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_sendavalancheproof_error_message
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19972
Build 39640: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39639: arc lint + arc unit