[Cashtab] [chronik utxo handling p4] Collect and apply required token metadata
ClosedPublic
Actions

Authored by bytesofman on Sep 8 2022, 23:51.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABCcc3a2c16d701: [Cashtab] [chronik utxo handling p4] Collect and apply required token metadata

Summary

T2447

Depends on D11934

Add a function to create the tokens wallet state object using chronik instead of bch-api

Test Plan

npm test
npm start, send and receive token txs, confirm the finalTokenArray object printed in the dev console shows the same balance as the one in wallet.state

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-utxo-handling-take2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19979
Build 39652: Build Diff	cashtab-tests
Build 39651: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 8 2022, 23:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2022, 23:51

bytesofman requested review of this revision.Sep 8 2022, 23:51

Harbormaster completed remote builds in B19969: Diff 34881.Sep 8 2022, 23:54

bytesofman retitled this revision from [Cashtab] [chronik utxo handling p3] Adding and caching token data to [Cashtab] [chronik utxo handling p4] Adding and caching token data.Sep 8 2022, 23:56

Rebase

Harbormaster completed remote builds in B19979: Diff 34894.Sep 9 2022, 14:03

Simplifying by removing token info cache

bytesofman retitled this revision from [Cashtab] [chronik utxo handling p4] Adding and caching token data to [Cashtab] [chronik utxo handling p4] Collect and apply required token metadata.Sep 9 2022, 15:57

bytesofman edited the summary of this revision. (Show Details)

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B19982: Diff 34897.Sep 9 2022, 15:58

kieran709 accepted this revision.Sep 9 2022, 18:09

This revision is now accepted and ready to land.Sep 9 2022, 18:09

bytesofman added a child revision: D11960: [Cashtab] [chronik utxo handling p5] Add support for caching token info to limit chronik API calls to unseen tokens.Sep 12 2022, 16:34

Closed by commit rABCcc3a2c16d701: [Cashtab] [chronik utxo handling p4] Collect and apply required token metadata (authored by bytesofman). · Explain WhySep 20 2022, 15:27

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCcc3a2c16d701: [Cashtab] [chronik utxo handling p4] Collect and apply required token metadata.