T2447
Depends on D11960
Add cashtabCache to local storage as a new unique key so that it is available across wallets.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC3a6c1902ea1f: [Cashtab] [chronik utxo handling p6] Cache token info in local storage
npm start
Observe that cashtabCache is added to local storage (dev console --> applications --> storage)
In dev console, observe that cashtabCache updates. First update call requires API calls for token info. Later ones do not.
Send a new token to the wallet and observe cashtabCache updates again.
Change wallets and confirm no errors, token cache still working.
Send and receive token txs, generally try to break it.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- chronik-utxo-handling-take2
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20002 Build 39693: Build Diff cashtab-tests Build 39692: arc lint + arc unit
Event Timeline
| web/cashtab/src/utils/__mocks__/mockCashtabCache.js | ||
|---|---|---|
| 2 ↗ | (On Diff #34933) | Not quite related to this diff but should we start incorporating the token type attribute into this series to make it easier to expand to cover NFTs when the eToken DEX lands in 3 months time? Because if we don't do it now, then we'll end up with the situation in 3 months time where we'll need to retrospectively refresh cache to update existing token info objects with their respective token types. |
| web/cashtab/src/utils/__tests__/validation.test.js | ||
| 273 ↗ | (On Diff #34933) | minor typo |
| 280 ↗ | (On Diff #34933) | I couldn't tell from the large mock array (cashtabCacheWithOneBadTokenId) whether it contained at least one token ID that is a string that is not exactly 64 chars. Might be worth its own test for malformed token ids. |
| web/cashtab/src/utils/validation.js | ||
| 260 ↗ | (On Diff #34933) | doc hash is optional in the UI so there may not be a value to check the type of |
| web/cashtab/src/utils/__mocks__/mockCashtabCache.js | ||
|---|---|---|
| 2 ↗ | (On Diff #34933) | While we will likely need to add this info going forward, the migration is trivial since this cache object automatically updates every time the utxo cycle is performed. So, I think it's okay to leave this out until we need it. |
| web/cashtab/src/utils/__tests__/validation.test.js | ||
| 273 ↗ | (On Diff #34933) | Corrected |
| 280 ↗ | (On Diff #34933) | Want to have a unit test that covers the specific ways isValidCashtabCache detects something is invalid, this is just one of those ways. We already have a specific function for isValidTokenId which has its own unit tests. So in effect, this is just testing whether isValidCashtabCache is appropriately using isValidTokenId |