Page MenuHomePhabricator
Differential D11984

GUI: Write PSBTs to file with binary mode
ClosedPublic
Actions

Authored by PiRK on Sep 14 2022, 09:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2867b3ddf04d: GUI: Write PSBTs to file with binary mode
Summary

PSBT files should be opened in binary mode as on windows, all newlines are turned into CRLF which produces invalid PSBTs.

This is a partial backport of core-gui#188

The change to psbtoperationsdialog.cpp is not applicable due to missing backports (core#18027)

Test Plan

Made sure that I can still save and load PSBT file in bitcoin-qt on Linux. I don't have a windows computer to compile and test this, but the change is trivial enough that it should not be necessary.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 14 2022, 09:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 14 2022, 09:29
PiRK requested review of this revision.Sep 14 2022, 09:29
teamcity edited the summary of this revision. (Show Details)Sep 14 2022, 09:29
PiRK edited the test plan for this revision. (Show Details)Sep 14 2022, 09:30
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D11983: [gui] Load PSBT from clipboard.
Harbormaster completed remote builds in B20032: Diff 34969.Sep 14 2022, 10:03
Fabien accepted this revision.Sep 15 2022, 09:44
This revision is now accepted and ready to land.Sep 15 2022, 09:44
PiRK abandoned this revision.Sep 20 2022, 07:48
PiRK mentioned this in D11975: fs: consistently use fsbridge:: for ifstream / ofstream.Sep 20 2022, 15:00
PiRK updated this revision to Diff 35024.Sep 20 2022, 15:27
PiRK edited the summary of this revision. (Show Details)

backport the applicable part without psbtoperationsdialog

This revision is now accepted and ready to land.Sep 20 2022, 15:27
PiRK removed a parent revision: D11983: [gui] Load PSBT from clipboard.Sep 20 2022, 15:35
PiRK added a child revision: D11975: fs: consistently use fsbridge:: for ifstream / ofstream.Sep 20 2022, 15:37
Fabien accepted this revision.Sep 20 2022, 15:39
Harbormaster completed remote builds in B20078: Diff 35024.Sep 20 2022, 15:39
Closed by commit rABC2867b3ddf04d: GUI: Write PSBTs to file with binary mode (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 20 2022, 15:55
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2867b3ddf04d: GUI: Write PSBTs to file with binary mode.

Revision Contents
Changeset List

PathSize
src/
qt/
3 lines

Diff 35047

View Options

src/qt/sendcoinsdialog.cpp

Loading...