Page MenuHomePhabricator

[Cashtab] fix antd syntax issue
ClosedPublic

Authored by kieran709 on Sep 26 2022, 17:51.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC79a6ad1bf2da: [Cashtab] fix antd syntax issue
Summary

Related to T2680. When clicking on a token from the eTokens list, then 'airdrop to holders,' antd fires an error in the console that reads 'visible will be removed in next major version, please use open instead.' According to the antd changelog for 4.23.0, the prop visible should be replaced with the prop open in: dropdowns, modals, drawers, tables, sliders and tooltip popovers. The visible prop is currently used by several modals throughout the app and is replaced in this diff with the open prop.

Test Plan

cd web/cashtab && npm start
Navigate to Settings screen and turn on send confirmation modal
using devtools, set screen resolution to mobile, then refresh, navigate back to Settings screen if necessary and turn on Auto-open camera if it is turned off.

Ensure that the following modals will still open:
Airdrop 'Querying the blockchain'
Create eToken image crop
Create eToken confirm eToken settings
Confirm send eToken
Confrim burn eToken
Add saved wallet to contacts list
Add new contact
Confirm delete contact
Rename contact
Rename wallet
Delete Wallet
Send Confirmation
Sign Message
Verify Message

Diff Detail

Repository
rABC Bitcoin ABC
Branch
find-and-fix-antd-syntax-issue
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20179
Build 40043: Build Diffcashtab-tests
Build 40042: arc lint + arc unit