Page MenuHomePhabricator
Differential D12150

Add generic SaltedSipHasher
ClosedPublic
Actions

Authored by PiRK on Oct 5 2022, 07:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4ad7cf9f6e27: Add generic SaltedSipHasher
Summary

SaltedSipHasher is a generic hasher that can be used with most things we
would hash in an unordered container.

Replace KeyIDHasher with SaltedSipHasher and remove now unused KeyIDHasher

Also remove an outdated comment which is no longer relevant since std::unordered_map is used instead of boost::unordered_map in CCoinsMap

This concludes backport of core#19935 and core#22772

https://github.com/bitcoin/bitcoin/pull/19935/commits/210b693db66e7c5b618014b5a287aee15af00045
https://github.com/bitcoin/bitcoin/pull/19935/commits/281fd1a4a032cded7f9ea9857e3e99fc793c714b
https://github.com/bitcoin/bitcoin/pull/22772/commits/16652a93ea6d25674fe318ef5e213e98427c8947
https://github.com/bitcoin/bitcoin/pull/22772/commits/4c69571e6eeae2c03d59045ea102baa5fd1c3816

Depends on D12149

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Oct 5 2022, 07:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2022, 07:33
PiRK requested review of this revision.Oct 5 2022, 07:33
teamcity edited the summary of this revision. (Show Details)Oct 5 2022, 07:33
Harbormaster completed remote builds in B20358: Diff 35437.Oct 5 2022, 07:55
Fabien requested changes to this revision.Oct 5 2022, 08:20
Fabien added a subscriber: Fabien.

The code looks good, but can you update the summary:

  • To fix the commit hashes
  • To mention the PR that removes KeyIDHasher, as it's not in the source material
This revision now requires changes to proceed.Oct 5 2022, 08:20
PiRK updated this revision to Diff 35438.Oct 5 2022, 09:42
PiRK edited the summary of this revision. (Show Details)
PiRK removed a reviewer: Fabien.

fix a commit url, and also backport core#22772 (follow-ups, including removal of unused KeyIDHasher)

Harbormaster completed remote builds in B20359: Diff 35438.Oct 5 2022, 10:13
Fabien accepted this revision.Oct 5 2022, 14:43
This revision is now accepted and ready to land.Oct 5 2022, 14:43
Closed by commit rABC4ad7cf9f6e27: Add generic SaltedSipHasher (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyOct 5 2022, 16:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4ad7cf9f6e27: Add generic SaltedSipHasher.

Revision Contents
Changeset List

PathSize
src/
util/
11 lines
10 lines
wallet/
9 lines

Diff 35437

View Options

src/util/hasher.h

Loading...
View Options

src/util/hasher.cpp

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...