Page MenuHomePhabricator
Differential D12163

Use C++11 member initializer in CTxMemPoolEntry
ClosedPublic
Actions

Authored by PiRK on Oct 6 2022, 13:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9731bc95ab78: Use C++11 member initializer in CTxMemPoolEntry
Summary

This removes a bunch of boilerplate, makes the code easier to read.
Also, C++11 member initialization avoids accidental uninitialized
members.

Can be reviewed with the git option "--word-diff-regex=." or with "git
difftool --tool=meld".

This is a backport of core#23054

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Oct 6 2022, 13:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2022, 13:06
PiRK requested review of this revision.Oct 6 2022, 13:06
teamcity edited the summary of this revision. (Show Details)Oct 6 2022, 13:07
Harbormaster completed remote builds in B20379: Diff 35472.Oct 6 2022, 13:23
Fabien added a subscriber: Fabien.Oct 6 2022, 14:49
Fabien added inline comments.
src/txmempool.cpp
33 ↗(On Diff #35472)

I don't understand why using this initializer prevents Wshadow. Any idea ?

PiRK updated this revision to Diff 35501.Oct 6 2022, 15:57

rename parameter ts -> _tx to make sure we do not trigger a Wshadow on any compiler.

Harbormaster completed remote builds in B20386: Diff 35501.Oct 6 2022, 16:11
Fabien accepted this revision.Oct 7 2022, 09:37
This revision is now accepted and ready to land.Oct 7 2022, 09:37
Closed by commit rABC9731bc95ab78: Use C++11 member initializer in CTxMemPoolEntry (authored by PiRK). · Explain WhyOct 7 2022, 09:54
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9731bc95ab78: Use C++11 member initializer in CTxMemPoolEntry.

Revision Contents
Changeset List

PathSize
src/
20 lines
29 lines

Diff 35501

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...