test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in `cnetaddr_basic`
ClosedPublic
Actions

Authored by PiRK on Oct 7 2022, 09:41.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC74bbb4ffb0f6: test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in…

Summary

I noticed this test failure in our CI for an unrelated diff (D12170)

This is a backport of core#21689

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21689

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20399
Build 40471: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40470: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 7 2022, 09:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2022, 09:41

PiRK requested review of this revision.Oct 7 2022, 09:41

teamcity edited the summary of this revision. (Show Details)Oct 7 2022, 09:41

Fabien accepted this revision.Oct 7 2022, 09:54

This revision is now accepted and ready to land.Oct 7 2022, 09:54

Harbormaster completed remote builds in B20399: Diff 35515.Oct 7 2022, 10:11

Closed by commit rABC74bbb4ffb0f6: test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 7 2022, 10:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC74bbb4ffb0f6: test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in….

PiRK mentioned this in D13312: net: Avoid calling getnameinfo when formatting IP addresses.Mar 13 2023, 14:52

PiRK mentioned this in rABC0442e823e50e: net: Avoid calling getnameinfo when formatting IP addresses.Mar 14 2023, 08:52

Revision Contents
Changeset List

Path

Size

src/

test/

net_tests.cpp

7 lines

Diff 35515

View Options

test: Remove intermittently failing and not very meaningful `BOOST_CHECK` in `cnetaddr_basic`ClosedPublicActions