Paths

Table of Contentst

Differential D12196

[Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name
ClosedPublic
Actions

Authored by kieran709 on Oct 10 2022, 20:26.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9327aeab5132: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get…

Summary

Added cashtabCache to context exports in useWallet.js, passed cashtabCache through Home.js to Tx.js. Added logic in Tx.js to look for the index of data.parsed.airdropTokenId in cashtabCache.tokenInfoById, if it is found, the tokenName is added to the Tx.

Depends on D12195

Test Plan

cd web/cashtab && npm start
if there are no sent or received airdrop txs in recent tx history, make them
observe that the token name is now visible under the token icon

Diff Detail

Repository

rABC Bitcoin ABC

Branch

parse-airdrops-tx-history

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20430
Build 40532: Build Diff	cashtab-tests
Build 40531: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 10 2022, 20:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2022, 20:26

kieran709 requested review of this revision.Oct 10 2022, 20:26

Harbormaster completed remote builds in B20430: Diff 35568.Oct 10 2022, 20:29

Add "Depends on D12195" to the Summary field of this diff to allow others to pull it for review.

This revision now requires changes to proceed.Oct 11 2022, 16:35

kieran709 edited the summary of this revision. (Show Details)Oct 18 2022, 14:39

kieran709 added a parent revision: D12195: [Cashtab][Pt1/2] Parse Airdrops in TxHistory.

Get errors when I npm start on this

image.png (628×493 px, 111 KB)

Responding to review feedback

Harbormaster completed remote builds in B20676: Diff 35948.Oct 21 2022, 18:37

bytesofman requested changes to this revision.Oct 24 2022, 17:59

bytesofman added inline comments.

web/cashtab/src/components/Home/Tx.js
694 ↗	(On Diff #35948)	Why `Object.entries(cashtabCache.tokenInfoById).indexOf(<tokenId>)` and not `Object.keys.includes(<tokenId>)` ?

This revision now requires changes to proceed.Oct 24 2022, 17:59

Fixed overly complicated conditional rendering per review feedback.

Harbormaster completed remote builds in B20708: Diff 35992.Oct 25 2022, 17:12

bytesofman accepted this revision.Oct 26 2022, 14:03

This revision is now accepted and ready to land.Oct 26 2022, 14:03

Closed by commit rABC9327aeab5132: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get… (authored by kieran709). · Explain WhyOct 26 2022, 16:24

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC9327aeab5132: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Home/

11 lines

26 lines

3 lines

hooks/

1 line

Diff 35568

web/cashtab/src/components/Home/Home.js

Loading...

web/cashtab/src/components/Home/Tx.js

Loading...

web/cashtab/src/components/Home/TxHistory.js

Loading...

web/cashtab/src/hooks/useWallet.js

Loading...