T2550
Depends on D12317
GetAddress component detects if user has Cashtab installed or not. If not, button becomes a link to install Cashtab.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCb7c4eb13cbc4: [Cashtab] [extension address passing p5] Add detection of Cashtab installation…
cd web/cashtab-components npm run storybook
The GetAddress component still displays as a button
Navigate to brave://extensions and disable your Cashtab extension(s)
Refresh the storybook
The GetAddress component button now says "Install Cashtab and refresh"
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- extension-address-passing-stack
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20619 Build 40903: Build Diff cashtab-components-tests Build 40902: arc lint + arc unit
Event Timeline
Comment Actions
When you click on GetAddress whilst the extension is disabled, it initially displays the GetAddress button before taking a little bit too long to switch to the 'Install Cashtab & refresh' button.
Comment Actions
The fix to this is not ideal. However, the component here is designed as a proof of concept / example. Actual implementations will vary depending on the website.
The right way to do this would be to upgrade the entire cashtab-components library to use hooks instead of classes. New task for this in T2756.
Since this is a separate task, I don't think this should hold up this extension feature.