Differential D12349

addrman: Log too low compat value
ClosedPublic
Actions

Authored by Fabien on Oct 21 2022, 09:29.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCafbc199feaa2: addrman: Log too low compat value

Summary

Also remove uint8_t{} casts from values that are already of the same type.

Backport of core#24312.

Depends on D12348.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR24312

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20662
Build 40988: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40987: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 21 2022, 09:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2022, 09:29

Fabien requested review of this revision.Oct 21 2022, 09:29

teamcity edited the summary of this revision. (Show Details)Oct 21 2022, 09:29

Harbormaster completed remote builds in B20662: Diff 35927.Oct 21 2022, 10:05

PiRK accepted this revision.Oct 21 2022, 12:08

This revision is now accepted and ready to land.Oct 21 2022, 12:08

Closed by commit rABCafbc199feaa2: addrman: Log too low compat value (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyOct 21 2022, 15:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCafbc199feaa2: addrman: Log too low compat value.

Revision Contents
Changeset List

Path

Size

src/

addrman.cpp

8 lines

test/

functional/

feature_addrman.py

12 lines

Diff 35927

View Options

src/addrman.cpp