Page MenuHomePhabricator
Differential D12361

MOVEONLY: move package unit tests to their own file
ClosedPublic
Actions

Authored by PiRK on Oct 22 2022, 09:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC789c3ac2417e: MOVEONLY: move package unit tests to their own file
Summary

I also removed all the includes that are now flagged as unused by my IDE in the source file. And a unit test was renamed during the move. Otherwise, there is no change in the code.

This is a partial backport of core#23381
https://github.com/bitcoin/bitcoin/pull/23381/commits/68763783658f004efd9117fa7a69b0e271c4eaaa

Depends on D12360

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 22 2022, 09:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2022, 09:22
PiRK requested review of this revision.Oct 22 2022, 09:22
teamcity edited the summary of this revision. (Show Details)Oct 22 2022, 09:22
PiRK edited the summary of this revision. (Show Details)Oct 22 2022, 09:23
PiRK added a parent revision: D12360: MOVEONLY: mempool checks to their own functions.
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)Oct 22 2022, 09:26
PiRK added a child revision: D12362: [test] call CheckPackage for package sanitization checks.Oct 22 2022, 09:26
Harbormaster completed remote builds in B20681: Diff 35953.Oct 22 2022, 09:46
Fabien accepted this revision.Oct 24 2022, 08:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/txpackage_tests.cpp
13 ↗(On Diff #35953)

You need this one

13 ↗(On Diff #35953)

revert

This revision is now accepted and ready to land.Oct 24 2022, 08:37
PiRK updated this revision to Diff 35963.Oct 24 2022, 13:02

fix includes as per review

This revision was landed with ongoing or failed builds.Oct 24 2022, 13:46
Closed by commit rABC789c3ac2417e: MOVEONLY: move package unit tests to their own file (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC789c3ac2417e: MOVEONLY: move package unit tests to their own file.
Harbormaster completed remote builds in B20686: Diff 35963.Oct 24 2022, 14:16

Revision Contents
Changeset List

PathSize
src/
test/
1 line
txpackage_tests.cpp
txvalidation_tests.cpp
42 lines
123 lines

Diff 35964

View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/txpackage_tests.cpp

Loading...
View Options

src/test/txvalidation_tests.cpp

Loading...