Page MenuHomePhabricator
Differential D12376

[Cashtab] [p1 remove BCH.getByteCount] Create an equivalent function with unit tests
ClosedPublic
Actions

Authored by bytesofman on Oct 26 2022, 23:30.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCf830ec2875a5: [Cashtab] [p1 remove BCH.getByteCount] Create an equivalent function with unit…
Summary

T2730

Create a new function getCashtabByteCount, which returns the exact same value as BCH.BitcoinCash.getByteCount()

Test Plan

Review new function, unit tests, and npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
replace-getbytecount
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20729
Build 41122: Build Diffcashtab-tests
Build 41121: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 26 2022, 23:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 26 2022, 23:30
bytesofman requested review of this revision.Oct 26 2022, 23:30
bytesofman updated this revision to Diff 36017.

Renaming function for clarity

bytesofman edited the summary of this revision. (Show Details)Oct 26 2022, 23:32
Harbormaster completed remote builds in B20727: Diff 36016.Oct 26 2022, 23:33
Harbormaster completed remote builds in B20728: Diff 36017.
bytesofman updated this revision to Diff 36018.Oct 26 2022, 23:35

Return number instead of string

bytesofman edited the summary of this revision. (Show Details)Oct 26 2022, 23:35
Harbormaster completed remote builds in B20729: Diff 36018.Oct 26 2022, 23:38
bytesofman added a child revision: D12377: [Cashtab] [p2 remove BCH.getByteCount] Replace BCH.getByteCount in calcFee.Oct 26 2022, 23:42
emack accepted this revision.Oct 27 2022, 03:57
This revision is now accepted and ready to land.Oct 27 2022, 03:57
Closed by commit rABCf830ec2875a5: [Cashtab] [p1 remove BCH.getByteCount] Create an equivalent function with unit… (authored by bytesofman). · Explain WhyOct 27 2022, 16:17
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf830ec2875a5: [Cashtab] [p1 remove BCH.getByteCount] Create an equivalent function with unit….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
__tests__/
38 lines
29 lines

Diff 36018

View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...