Page MenuHomePhabricator
Differential D1309

Fix a couple of nits in miner.cpp
ClosedPublic
Actions

Authored by schancel on Apr 26 2018, 17:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0dc47a5aeb85: Fix a couple of nits in miner.cpp
rABC0dc47a5aeb85: Fix a couple of nits in miner.cpp
Summary

See title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
miner
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2393
Build 2915: Bitcoin ABC Buildbot (legacy)
Build 2914: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 26 2018, 17:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2018, 17:01
teamcity added a subscriber: teamcity.Apr 26 2018, 17:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 26 2018, 17:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2385: Diff 3597.Apr 26 2018, 17:21
deadalnix requested changes to this revision.Apr 27 2018, 03:04
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/miner.cpp
436 ↗(On Diff #3597)

This comment's formatting is fubared. You can put it on one line and let clang format do it's magic.

559 ↗(On Diff #3597)

likestamp

This revision now requires changes to proceed.Apr 27 2018, 03:04
schancel updated this revision to Diff 3607.Apr 27 2018, 15:40

Fix comment formatting

teamcity added a comment.Apr 27 2018, 15:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix accepted this revision.Apr 27 2018, 15:49
This revision is now accepted and ready to land.Apr 27 2018, 15:49
teamcity added a comment.Apr 27 2018, 16:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 27 2018, 16:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2393: Diff 3607.Apr 27 2018, 16:21
Closed by commit rABC0dc47a5aeb85: Fix a couple of nits in miner.cpp (authored by schancel). · Explain WhyApr 27 2018, 16:34
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
42 lines

Diff 3607

View Options

src/miner.cpp

Loading...