T2730
As a prerequisite to deprecating BCH.Address.toHash160(), this diff implements a local swiss army knife version of toHash160() that converts ecash, etoken, bitcoincash and simpleledger addresses to hash160.
Relies on the bs58 library (6KB).
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC059d6e18b38f: [Cashtab] [BCH deprecation] Pt 1/2 - Implement local toHash160 logic
- npm install or npm i bs58
- npm test and ensure all toHash160 unit tests pass
- npm start
- send a private message to another address and observe the 'getRecipientPublicKey(): recipientAddressHash160 matches localRecipientAddressHash160' console log message
- create a new wallet and observe the 'deriveAccount(): hash160 matches localhash160' console log message'
- send a private message using the new wallet and observe the 'getRecipientPublicKey(): recipientAddressHash160 matches localRecipientAddressHash160' console log message
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- deprecateToHash160
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20764 Build 41191: Build Diff cashtab-tests Build 41190: arc lint + arc unit
Event Timeline
| web/cashtab/src/utils/cashMethods.js | ||
|---|---|---|
| 876 ↗ | (On Diff #36076) | Is this based off a reference function from bch-js? If so, please link |
| web/cashtab/src/utils/cashMethods.js | ||
|---|---|---|
| 876 ↗ | (On Diff #36076) | no not based off the bch-js function, this is just the standard approach outlined in the bs58 library readme https://www.npmjs.com/package/bs58 |