Page MenuHomePhabricator

[Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.toHash160
ClosedPublic

Authored by emack on Oct 30 2022, 12:47.

Details

Summary

T2730

Depends on D12395

This diff switches out all uses of the BCH-JS toHash160() function to the local implementation.

Test Plan
  • npm test and ensure existing unit tests pass
  • grep -r 'BCH.Address.toHash160' src/ and ensure no further use of this external function
  • npm start
  • send a private message to another address and ensure successful decryption on the receiving wallet
  • create a new wallet (to trigger deriveAccount()), then send a private message using the new wallet and ensure successful decryption on the receiving wallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecateToHash160
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20767
Build 41197: Build Diffcashtab-tests
Build 41196: arc lint + arc unit