Differential D12395

[Cashtab] [BCH deprecation] Pt 1/2 - Implement local toHash160 logic
ClosedPublic
Actions

Authored by emack on Oct 30 2022, 04:47.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC059d6e18b38f: [Cashtab] [BCH deprecation] Pt 1/2 - Implement local toHash160 logic

Summary

T2730

As a prerequisite to deprecating BCH.Address.toHash160(), this diff implements a local swiss army knife version of toHash160() that converts ecash, etoken, bitcoincash and simpleledger addresses to hash160.

Relies on the bs58 library (6KB).

Test Plan

npm install or npm i bs58
npm test and ensure all toHash160 unit tests pass
npm start
send a private message to another address and observe the 'getRecipientPublicKey(): recipientAddressHash160 matches localRecipientAddressHash160' console log message
create a new wallet and observe the 'deriveAccount(): hash160 matches localhash160' console log message'
send a private message using the new wallet and observe the 'getRecipientPublicKey(): recipientAddressHash160 matches localRecipientAddressHash160' console log message

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Oct 30 2022, 04:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2022, 04:47

updated package.json

Harbormaster completed remote builds in B20764: Diff 36074.Oct 30 2022, 04:50

Harbormaster completed remote builds in B20765: Diff 36075.

Removed redundant validation

emack edited the summary of this revision. (Show Details)Oct 30 2022, 04:56

Harbormaster completed remote builds in B20766: Diff 36076.Oct 30 2022, 04:58

emack mentioned this in D12390: [Cashtab] [BCH deprecation] Pt 1/2 - Implement local toLegacyAddress logic.Oct 30 2022, 12:08

emack added a child revision: D12396: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.toHash160.Oct 30 2022, 12:47

bytesofman accepted this revision.Oct 31 2022, 16:38

bytesofman added inline comments.

web/cashtab/src/utils/cashMethods.js
876 ↗	(On Diff #36076)	Is this based off a reference function from bch-js? If so, please link

This revision is now accepted and ready to land.Oct 31 2022, 16:38

emack marked an inline comment as done.Nov 1 2022, 02:54

emack added inline comments.

web/cashtab/src/utils/cashMethods.js
876 ↗	(On Diff #36076)	no not based off the bch-js function, this is just the standard approach outlined in the bs58 library readme https://www.npmjs.com/package/bs58