Paths

Table of Contentst

Differential D12396

[Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.toHash160
ClosedPublic
Actions

Authored by emack on Oct 30 2022, 12:47.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7abded36649a: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.toHash160

Summary

T2730

Depends on D12395

This diff switches out all uses of the BCH-JS toHash160() function to the local implementation.

Test Plan

npm test and ensure existing unit tests pass
grep -r 'BCH.Address.toHash160' src/ and ensure no further use of this external function
npm start
send a private message to another address and ensure successful decryption on the receiving wallet
create a new wallet (to trigger deriveAccount()), then send a private message using the new wallet and ensure successful decryption on the receiving wallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Oct 30 2022, 12:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2022, 12:47

emack requested review of this revision.Oct 30 2022, 12:47

Harbormaster completed remote builds in B20767: Diff 36077.Oct 30 2022, 12:50

bytesofman accepted this revision.Oct 31 2022, 16:39

This revision is now accepted and ready to land.Oct 31 2022, 16:39

Closed by commit rABC7abded36649a: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.toHash160 (authored by emack). · Explain WhyNov 1 2022, 04:24

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC7abded36649a: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.toHash160.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

16 lines

8 lines

Diff 36097

web/cashtab/src/hooks/useBCH.js

Loading...

web/cashtab/src/hooks/useWallet.js

Loading...