[Cashtab] Remove testnet instantiations and unit tests
ClosedPublic
Actions

Authored by emack on Nov 2 2022, 00:47.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC52c7d8f32d9c: [Cashtab] Remove testnet instantiations and unit tests

Summary

As per TG discussion, removing the redundant testnet environment instantiations and testnet specific unit tests.

Test Plan

npm test and ensure existing test suites all pass
npm start
grep -r 'testnet' src/ and ensure the only results are the 'testnet: false' attribute in mockTxBuilderObj.js
create a new wallet (to trigger getWalletDetails) and ensure the successful creation of the wallet
send a normal XEC tx to this new wallet's receiving address and ensure successful tx

Diff Detail

Repository

rABC Bitcoin ABC

Branch

removeTestnetLogic

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20810
Build 41279: Build Diff	cashtab-tests
Build 41278: arc lint + arc unit

Event Timeline

emack created this revision.Nov 2 2022, 00:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2022, 00:47

emack requested review of this revision.Nov 2 2022, 00:47

Harbormaster completed remote builds in B20795: Diff 36116.Nov 2 2022, 00:50

Let's take out all the testnet stuff in this diff, i.e.

grep -r REACT_APP_BCHA_APIS_TEST src/

Also pull that variable out of .env

This revision now requires changes to proceed.Nov 5 2022, 04:24

Removed all instances of REACT_APP_BCHA_APIS_TEST including .env, which subsequently made the REACT_APP_NETWORK param redundant, hence its inclusion in this removal as well.

Harbormaster completed remote builds in B20810: Diff 36136.Nov 5 2022, 13:53

bytesofman accepted this revision.Nov 6 2022, 07:16

This revision is now accepted and ready to land.Nov 6 2022, 07:16

Closed by commit rABC52c7d8f32d9c: [Cashtab] Remove testnet instantiations and unit tests (authored by emack). · Explain WhyNov 6 2022, 08:42

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC52c7d8f32d9c: [Cashtab] Remove testnet instantiations and unit tests.