T2730
Part 1 of a 2-part stacked diff
Fork the bch-js dependency bitcoinjs-message to support addresses in ecashaddr format
Note: This function should have never been async. So, this will also be deprecated in the second part of the stack.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project
Review changes to the bitcoinjs-message dependency here: https://github.com/BytesOfMan/bitcoinjs-message/pull/1
npm start
Test out a few valid signatures. Check dev console for Both signature verification methods return the same result
npm start
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- deprecate-verify-msg
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20813 Build 41285: Build Diff cashtab-tests Build 41284: arc lint + arc unit
Event Timeline
Comment Actions
Using the electrum message signer as a reference, this only works for Bitcoin signatures but not eCash signatures. I think this was the existing limitation with the bch-js library so worth consider adding eCash verification to this part 1?
Comment Actions
Due to significant conflicts from moving signatures off the send screen in D12426 stack, abandoning this. Will be submitted as a new stack.