Page MenuHomePhabricator
Differential D12474

[packages] add static IsChildWithParents function
ClosedPublic
Actions

Authored by PiRK on Nov 11 2022, 04:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3addc7fab2d3: [packages] add static IsChildWithParents function
Summary

This is a partial backport of core#22674
https://github.com/bitcoin/bitcoin/pull/22674/commits/9b2fdca7f03911ac40fe0f8a0b5da534bee4554b
https://github.com/bitcoin/bitcoin/pull/22674/commits/ba26169f6035c238378a3c9647213328a006fa23

Test Plan

ninja && ninja check`

Diff Detail

Event Timeline

PiRK created this revision.Nov 11 2022, 04:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2022, 04:39
PiRK requested review of this revision.Nov 11 2022, 04:39
teamcity edited the summary of this revision. (Show Details)Nov 11 2022, 04:39
Harbormaster completed remote builds in B20886: Diff 36254.Nov 11 2022, 04:56
Fabien requested changes to this revision.Nov 11 2022, 08:11
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/txpackage_tests.cpp
168 ↗(On Diff #36254)

Please make it 49

This revision now requires changes to proceed.Nov 11 2022, 08:11
PiRK updated this revision to Diff 36255.Nov 11 2022, 10:29

bump number of transactions in package to 49 in test

Harbormaster completed remote builds in B20887: Diff 36255.Nov 11 2022, 10:45
Fabien accepted this revision.Nov 11 2022, 11:39
This revision is now accepted and ready to land.Nov 11 2022, 11:39
Closed by commit rABC3addc7fab2d3: [packages] add static IsChildWithParents function (authored by glozow <gloriajzhao@gmail.com>, committed by PiRK). · Explain WhyNov 14 2022, 08:42
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3addc7fab2d3: [packages] add static IsChildWithParents function.

Revision Contents
Changeset List

PathSize
src/
policy/
9 lines
23 lines
test/
106 lines

Diff 36255

View Options

src/policy/packages.h

Loading...
View Options

src/policy/packages.cpp

Loading...
View Options

src/test/txpackage_tests.cpp

Loading...