Page MenuHomePhabricator
Differential D1323

[cmake][secp256k1] Check is amd64 asm is supported and if so, use it.
ClosedPublic
Actions

Authored by deadalnix on Apr 29 2018, 00:14.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGd73ca175fdd5: [cmake][secp256k1] Check is amd64 asm is supported and if so, use it.
rABCd73ca175fdd5: [cmake][secp256k1] Check is amd64 asm is supported and if so, use it.
Summary

As per title. This makes things much faster.

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secpcmakeasm
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2402
Build 2933: Bitcoin ABC Buildbot (legacy)
Build 2932: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 29 2018, 00:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2018, 00:14
teamcity added a subscriber: teamcity.Apr 29 2018, 00:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 29 2018, 00:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2402: Diff 3630.Apr 29 2018, 00:33
deadalnix updated this revision to Diff 3633.Apr 29 2018, 12:54

Update field implementation availability to take asm support into account

teamcity added a comment.Apr 29 2018, 12:56

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2404: Diff 3633.Apr 29 2018, 13:15
teamcity added a comment.Apr 29 2018, 13:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel accepted this revision.Apr 30 2018, 20:11
schancel added a subscriber: schancel.
schancel added inline comments.
src/secp256k1/CMakeLists.txt
76 ↗(On Diff #3633)

insline -> inline

This revision is now accepted and ready to land.Apr 30 2018, 20:11
Closed by commit rABCd73ca175fdd5: [cmake][secp256k1] Check is amd64 asm is supported and if so, use it. (authored by deadalnix). · Explain WhyMay 1 2018, 01:02
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
10 lines
src/
2 lines

Diff 3630

View Options

src/secp256k1/CMakeLists.txt

Loading...
View Options

src/secp256k1/src/libsecp256k1-config.h.cmake.in

Loading...