Differential D12451

[Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate locally
ClosedPublic
Actions

Authored by emack on Nov 10 2022, 07:09.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0a9bc99f3595: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate…

Summary

T2730

Depends on D12450

Stacked diff to localize existing uses of BCH.Mnemonic throughout the app and deprecate the BCH.Mnemonic object.

Relies on the randombytes library.

Pt 1/7 - Implement BCH.Mnemonic.toSeed locally
Pt 2/7 - Implement BCH.Mnemonic.generate locally
Pt 3/7 - Implement BCH.Mnemonic.wordLists locally
Pt 4/7 - Implement BCH.Mnemonic.validate locally
Pt 5/7 - Deprecate BCH.Mnemonic throughout the app
Pt 6/7 - Optimize bip39 bundle via webpack IgnorePlugin
Pt 7/7 - Unwrap validateMnemonicWordList

Test Plan

npm test
npm start
create a new wallet and observe the generated mnemonic in the console log
test receiving and sending XEC from this new wallet
note: by virtue of randombytes being used by BCH-JS the generated mnemonics will never match

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20995
Build 41644: Build Diff	cashtab-tests
Build 41643: arc lint + arc unit

Event Timeline

emack created this revision.Nov 10 2022, 07:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 07:09

emack requested review of this revision.Nov 10 2022, 07:09

Harbormaster completed remote builds in B20857: Diff 36205.Nov 10 2022, 07:11

emack added a child revision: D12452: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic.wordLists locally.Nov 10 2022, 07:28

bytesofman accepted this revision.Nov 10 2022, 10:01

This revision is now accepted and ready to land.Nov 10 2022, 10:01

emack retitled this revision from [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/5 - Implement BCH.Mnemonic.generate locally to [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/6 - Implement BCH.Mnemonic.generate locally.Nov 10 2022, 12:58

emack edited the summary of this revision. (Show Details)

emack retitled this revision from [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/6 - Implement BCH.Mnemonic.generate locally to [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate locally.Nov 14 2022, 12:06

emack edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B20995: Diff 36412.Nov 20 2022, 00:22

Closed by commit rABC0a9bc99f3595: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate… (authored by emack). · Explain WhyNov 22 2022, 21:49

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC0a9bc99f3595: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 2/7 - Implement BCH.Mnemonic.generate….