[cmake] Make sure FindZeroMQ.cmake set the right variables
ClosedPublic
Actions

Authored by deadalnix on May 1 2018, 15:59.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa03c1bd69b8d: [cmake] Make sure FindZeroMQ.cmake set the right variables
rABCa03c1bd69b8d: [cmake] Make sure FindZeroMQ.cmake set the right variables

Summary

This ensure that parameters like REQUIRED are handled as expected.

Test Plan

Delete libzmq from my system

cmake -GNinja ..

Make sure we get the error

Could NOT find ZeroMQ (missing: ZMQ_INCLUDE_DIR ZMQ_LIBRARY)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

zmqcmake

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2421
Build 2971: Bitcoin ABC Buildbot (legacy)
Build 2970: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 1 2018, 15:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2018, 15:59

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2421: Diff 3659.May 1 2018, 16:17

schancel accepted this revision.May 1 2018, 16:24

This revision is now accepted and ready to land.May 1 2018, 16:24

Closed by commit rABCa03c1bd69b8d: [cmake] Make sure FindZeroMQ.cmake set the right variables (authored by deadalnix). · Explain WhyMay 1 2018, 16:37

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

FindZeroMQ.cmake

10 lines

Diff 3659

View Options

cmake/modules/FindZeroMQ.cmake

[cmake] Make sure FindZeroMQ.cmake set the right variablesClosedPublicActions