[Cashtab] [xecjs-message upgrade p1/3] Deprecate segwit support from xecjs-message
ClosedPublic
Actions

Authored by bytesofman on Nov 26 2022, 07:19.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC716956d74b9f: [Cashtab] [xecjs-message upgrade p1/3] Deprecate segwit support from xecjs…

Summary

T2784

Remove segwit support from the xecjs-message library. Test the async signing function in Cashtab to verify that segwit removal did not break any modified functions.

Publish this version to npm as a tagged dev release so that unit tests in Cashtab are not broken by local dependency.

Test Plan

npm start
Sign a message
Confirm dev log displays 'Both methods not broken'
Verify a message
Confirm verification

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21171
Build 41994: Build Diff	cashtab-tests
Build 41993: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 26 2022, 07:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2022, 07:19

bytesofman requested review of this revision.Nov 26 2022, 07:19

bytesofman retitled this revision from [Cashtab] [xecjs-message upgrade p1] Deprecate segwit support from xecjs-message to [Cashtab] [xecjs-message upgrade p1/3] Deprecate segwit support from xecjs-message.Nov 26 2022, 07:20

Harbormaster completed remote builds in B21168: Diff 36680.Nov 26 2022, 07:21

bytesofman added a child revision: D12646: [Cashtab] [xecjs-message upgrade p2/3] Sign msgs with ecash prefix in xecjs-message.Nov 26 2022, 07:22

rebase and npm i

Harbormaster completed remote builds in B21171: Diff 36683.Nov 26 2022, 07:30

emack accepted this revision.Nov 26 2022, 12:26

This revision is now accepted and ready to land.Nov 26 2022, 12:26

Closed by commit rABC716956d74b9f: [Cashtab] [xecjs-message upgrade p1/3] Deprecate segwit support from xecjs… (authored by bytesofman). · Explain WhyNov 26 2022, 13:35

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC716956d74b9f: [Cashtab] [xecjs-message upgrade p1/3] Deprecate segwit support from xecjs….