Page MenuHomePhabricator
Differential D12625

[Cashtab] [Simplify wallet structure p4] Remove parent artifact object slpBalancesAndUtxos
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 12:32.

Details

Reviewers
kieran709
Group Reviewers
Restricted Project
Commits
rABC4c16d6340964: [Cashtab] [Simplify wallet structure p4] Remove parent artifact object…
Summary

T2663

Depends on D12593

Remove parent object slpBalancesAndUtxos from wallet structure

Note: this means that this wallet structure should not longer be supported by any functions in Cashtab...with the exceptions of isValidStoredWallet (because stored wallets may be in the old format) and loadStoredWallet (for the same reason)

Hence, this diff modifies mocks in existing unit tests.

Test Plan

Review unit test mock changes and npm test
npm start
Wait to see dev console msg that active wallet has been updated. Confirm by reviewing local storage.
Change wallets. Wait to see dev console msg that active wallet has been updated. Confirm by reviewing local storage.
Switch back to original wallet. Confirm both used wallets are stored correctly in local storage.
Send an XEC tx
Create a token
Burn a token
Send an eToken tx

Diff Detail

Event Timeline

bytesofman created this revision.Nov 25 2022, 12:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 12:32
bytesofman requested review of this revision.Nov 25 2022, 12:32
bytesofman edited the summary of this revision. (Show Details)Nov 25 2022, 12:32
bytesofman added a parent revision: D12593: [Cashtab] [Simplify wallet structure p3] Remove unused utxos array.
Harbormaster completed remote builds in B21135: Diff 36625.Nov 25 2022, 12:35
bytesofman updated this revision to Diff 36689.Nov 26 2022, 07:41

rebase

Harbormaster completed remote builds in B21177: Diff 36689.Nov 26 2022, 07:44
kieran709 accepted this revision.Nov 26 2022, 08:16
This revision is now accepted and ready to land.Nov 26 2022, 08:16
bytesofman updated this revision to Diff 36725.Nov 28 2022, 04:50

rebase

bytesofman added a child revision: D12659: [Cashtab] [Simplify wallet structure p5] Remove function specific variable name change.Nov 28 2022, 04:56
Harbormaster completed remote builds in B21199: Diff 36725.Nov 28 2022, 05:11
bytesofman updated this revision to Diff 36805.Nov 30 2022, 08:16

rebase

Harbormaster completed remote builds in B21255: Diff 36805.Nov 30 2022, 08:41
teamcity added a comment.Nov 30 2022, 08:41
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo ======
Error: expect(received).toStrictEqual(expected) // deep equality

Expected: [Error: No token UTXOs for the specified token could be found.]
Received: [TypeError: Cannot destructure property 'tokenId' of 'undefined' as it is undefined.]
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:211:29)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo

bytesofman updated this revision to Diff 36824.Nov 30 2022, 15:54

Patching merge conflict error

Harbormaster completed remote builds in B21272: Diff 36824.Nov 30 2022, 15:57
Closed by commit rABC4c16d6340964: [Cashtab] [Simplify wallet structure p4] Remove parent artifact object… (authored by bytesofman). · Explain WhyDec 1 2022, 07:57
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC4c16d6340964: [Cashtab] [Simplify wallet structure p4] Remove parent artifact object….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
8 lines
hooks/
__mocks__/
682 lines
33 lines
__tests__/
4 lines
24 lines
8 lines
utils/
__mocks__/
196 lines
8 lines
480 lines
__tests__/
6 lines
2 lines
19 lines
8 lines

Diff 36689

View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/hooks/__mocks__/burnToken.js

Loading...
View Options

web/cashtab/src/hooks/__mocks__/createToken.js

Loading...
View Options

web/cashtab/src/hooks/__tests__/useBCH.test.js

Loading...
View Options

web/cashtab/src/hooks/useBCH.js

Loading...
View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikTxHistory.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/mockCachedUtxos.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/mockStoredWallets.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...