Paths

Table of Contentst

Differential D12648

[Cashtab] Fallback to block time if timeFirstSeen is zero
ClosedPublic
Actions

Authored by bytesofman on Nov 26 2022, 07:49.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCb17d944a7ddb: [Cashtab] Fallback to block time if timeFirstSeen is zero

Summary

T2806

If chronik has not seen a tx, timeFirstSeen will be zero and Cashtab will parse the tx as having been sent in 1970.

Fall back to blocktime in this case to get a mostly accurate time estimate.

Test Plan

Ping me on Telegram for a wallet seed with some txs in this category
Import at cashtab.com and note wrong dates
npm start and confirm accurate dates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-timefirstseen-fallback

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21178
Build 42008: Build Diff	cashtab-tests
Build 42007: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 26 2022, 07:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2022, 07:49

bytesofman requested review of this revision.Nov 26 2022, 07:49

Harbormaster completed remote builds in B21178: Diff 36690.Nov 26 2022, 07:51

emack accepted this revision.Nov 26 2022, 12:07

This revision is now accepted and ready to land.Nov 26 2022, 12:07

Closed by commit rABCb17d944a7ddb: [Cashtab] Fallback to block time if timeFirstSeen is zero (authored by bytesofman). · Explain WhyNov 26 2022, 13:22

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCb17d944a7ddb: [Cashtab] Fallback to block time if timeFirstSeen is zero.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Home/

Tx.js

5 lines

Diff 36690

View Options

web/cashtab/src/components/Home/Tx.js

[Cashtab] Fallback to block time if timeFirstSeen is zeroClosedPublicActions