Page MenuHomePhabricator
Differential D12658

[Chronik] Move `HashToArray` to util/hash.cpp/h
ClosedPublic
Actions

Authored by tobias_ruck on Nov 27 2022, 17:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCac03125b394b: [Chronik] Move `HashToArray` to util/hash.cpp/h
Summary

This is useful in e.g. chronik_validationinterface.cpp, and having it in chronik_bridge.cpp/h is a bit out of place.

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-move-hashtoarray
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21188
Build 42028: Build Diffbuild-chronik
Build 42027: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Nov 27 2022, 17:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2022, 17:58
tobias_ruck requested review of this revision.Nov 27 2022, 17:58
Harbormaster completed remote builds in B21188: Diff 36707.Nov 27 2022, 18:03
teamcity added a comment.Nov 27 2022, 18:03
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

[357/537] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[358/537] Linking CXX static library src/libcommon.a
[359/537] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[360/537] Linking C executable src/secp256k1/recover-bench
[361/537] Linking C executable src/secp256k1/ecmult-bench
[362/537] Linking C executable src/secp256k1/verify-bench
[363/537] Linking CXX static library src/libscript.a
[364/537] Linking C executable src/secp256k1/sign-bench
[365/537] Linking CXX static library src/libbitcoinconsensus.a
[366/537] Linking CXX shared library src/libbitcoinconsensus.so.0.26.7
[367/537] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[368/537] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[369/537] Linking C executable src/secp256k1/internal-bench
[370/537] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[371/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[372/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[373/537] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[374/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[375/537] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[376/537] Linking CXX executable src/bitcoin-cli
[377/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[378/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[379/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[380/537] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[381/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[382/537] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[383/537] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[384/537] Linking CXX executable src/bitcoin-tx
[385/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[386/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[387/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[388/537] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[389/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[390/537] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[391/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[392/537] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[393/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[394/537] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[395/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[396/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[397/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[398/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[399/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[400/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[401/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[402/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[403/537] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[404/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[405/537] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[406/537] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[407/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[408/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[409/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[410/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[411/537] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[412/537] Linking CXX static library src/wallet/libwallet.a
[413/537] Linking CXX static library src/wallet/libwallet-tool.a
[414/537] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
tobias_ruck updated this revision to Diff 36708.Nov 27 2022, 18:10

Add missing <algorithm> import

Harbormaster completed remote builds in B21189: Diff 36708.Nov 27 2022, 18:17
teamcity added a comment.Nov 27 2022, 18:17
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

[487/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin-qt-base_autogen/mocs_compilation.cpp.o
[488/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/clientmodel.cpp.o
[489/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin.cpp.o
[490/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoin.cpp.o
[491/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/intro.cpp.o
[492/537] Linking CXX executable src/bench/bitcoin-bench
FAILED: src/bench/bitcoin-bench 
: && /usr/bin/c++ -g -O2 -fuse-ld=gold -Wl,-z,relro -Wl,-z,now -fPIE -pie src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o src/test/CMakeFiles/testutil.dir/util/logging.cpp.o src/test/CMakeFiles/testutil.dir/util/mining.cpp.o src/test/CMakeFiles/testutil.dir/util/net.cpp.o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o src/test/CMakeFiles/testutil.dir/util/str.cpp.o src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/addrman.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/base58.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/bench.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/bench_bitcoin.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/block_assemble.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/cashaddr.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/ccoins_caching.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/chacha_poly_aead.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/chacha20.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/checkblock.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/checkqueue.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/crypto_aes.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/crypto_hash.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/data.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/duplicate_inputs.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/examples.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/gcs_filter.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/hashpadding.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/lockedpool.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/mempool_eviction.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/mempool_stress.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/merkle_root.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/nanobench.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/peer_eviction.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/poly1305.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/prevector.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/rollingbloom.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/rpc_blockchain.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/rpc_mempool.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/util_time.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/verify_script.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/coin_selection.cpp.o src/bench/CMakeFiles/bitcoin-bench.dir/wallet_balance.cpp.o -o src/bench/bitcoin-bench  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  src/wallet/libwallet.a  src/libserver.a  src/wallet/libwallet.a  /usr/lib/x86_64-linux-gnu/libdb_cxx.so  /usr/lib/x86_64-linux-gnu/libsqlite3.so  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/secp256k1/libsecp256k1.a  src/leveldb/libmemenv.a  /usr/lib/x86_64-linux-gnu/libevent_pthreads.so  /usr/lib/x86_64-linux-gnu/libminiupnpc.so  /usr/lib/x86_64-linux-gnu/libnatpmp.so  src/zmq/libzmq.a  /usr/lib/x86_64-linux-gnu/libzmq.so  chronik/libchronik.a  chronik/libchronik_lib.a  -lrt  -lpthread  -lgcc_s  -lc  chronik/libchronik-bridge.a  src/leveldb/libleveldb.a  src/leveldb/libleveldb-sse4.2.a  src/libutil.a  src/univalue/libunivalue.a  /usr/lib/x86_64-linux-gnu/libevent.so  src/crypto/libcrypto.a  src/crypto/libcrypto_sse4.1.a  src/crypto/libcrypto_avx2.a  src/crypto/libcrypto_shani.a  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  -lm  -ldl  /usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.74.0  /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.74.0  -pthread  /usr/lib/x86_64-linux-gnu/libboost_atomic.so.1.74.0 && :
../../chronik/chronik-cpp/chronik_bridge.cpp:39: error: undefined reference to 'chronik::HashToArray(uint256 const&)'
collect2: error: ld returned 1 exit status
[493/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/bitcoingui.cpp.o
[494/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/guiutil.cpp.o
[495/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsdialog.cpp.o
[496/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroltreewidget.cpp.o
[497/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/optionsmodel.cpp.o
[498/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/createwalletdialog.cpp.o
[499/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addressbookpage.cpp.o
[500/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/utilitydialog.cpp.o
[501/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/trafficgraphwidget.cpp.o
[502/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/askpassphrasedialog.cpp.o
[503/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin_locale.cpp.o
[504/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/editaddressdialog.cpp.o
[505/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/splashscreen.cpp.o
[506/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrimagewidget.cpp.o
[507/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/peertablemodel.cpp.o
[508/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/openuridialog.cpp.o
[509/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addresstablemodel.cpp.o
[510/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionfilterproxy.cpp.o
[511/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/overviewpage.cpp.o
[512/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondescdialog.cpp.o
[513/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o
[514/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsentry.cpp.o
[515/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receivecoinsdialog.cpp.o
[516/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionrecord.cpp.o
[517/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroldialog.cpp.o
[518/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/recentrequeststablemodel.cpp.o
[519/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o
[520/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/signverifymessagedialog.cpp.o
[521/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionview.cpp.o
[522/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodeltransaction.cpp.o
[523/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletframe.cpp.o
[524/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentserver.cpp.o
[525/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiontablemodel.cpp.o
[526/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondesc.cpp.o
[527/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentrequestplus.cpp.o
[528/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsdialog.cpp.o
[529/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletcontroller.cpp.o
[530/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletview.cpp.o
[531/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodel.cpp.o
[532/537] Linking CXX static library src/qt/libbitcoin-qt-base.a
[533/537] Automatic MOC for target bitcoin-qt
[534/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o
[535/537] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o
[536/537] Linking CXX executable src/qt/bitcoin-qt
FAILED: src/qt/bitcoin-qt 
: && /usr/bin/c++ -g -O2 -fuse-ld=gold -Wl,-z,relro -Wl,-z,now -fPIE -pie src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o -o src/qt/bitcoin-qt  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  src/qt/libbitcoin-qt-base.a  src/libserver.a  src/leveldb/libmemenv.a  /usr/lib/x86_64-linux-gnu/libevent_pthreads.so  /usr/lib/x86_64-linux-gnu/libminiupnpc.so  /usr/lib/x86_64-linux-gnu/libnatpmp.so  src/zmq/libzmq.a  /usr/lib/x86_64-linux-gnu/libzmq.so  chronik/libchronik.a  chronik/libchronik_lib.a  -lrt  -lpthread  -lgcc_s  -lc  chronik/libchronik-bridge.a  src/leveldb/libleveldb.a  src/leveldb/libleveldb-sse4.2.a  src/librpcclient.a  /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.15.2  /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.15.2  /usr/lib/x86_64-linux-gnu/libQt5Network.so.5.15.2  /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.15.2  /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.15.2  /usr/lib/x86_64-linux-gnu/libssl.so  /usr/lib/x86_64-linux-gnu/libcrypto.so  /usr/lib/x86_64-linux-gnu/libprotobuf.so  src/wallet/libwallet.a  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/libutil.a  /usr/lib/x86_64-linux-gnu/libevent.so  src/crypto/libcrypto.a  src/crypto/libcrypto_sse4.1.a  src/crypto/libcrypto_avx2.a  src/crypto/libcrypto_shani.a  /usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.74.0  /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.74.0  /usr/lib/x86_64-linux-gnu/libboost_atomic.so.1.74.0  src/secp256k1/libsecp256k1.a  src/univalue/libunivalue.a  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  -lm  -pthread  -ldl  /usr/lib/x86_64-linux-gnu/libdb_cxx.so  /usr/lib/x86_64-linux-gnu/libsqlite3.so  /usr/lib/x86_64-linux-gnu/libqrencode.so && :
../../chronik/chronik-cpp/chronik_bridge.cpp:39: error: undefined reference to 'chronik::HashToArray(uint256 const&)'
collect2: error: ld returned 1 exit status
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
tobias_ruck updated this revision to Diff 36709.Nov 27 2022, 20:12

pleasing GCC (fingers crossed)

Harbormaster completed remote builds in B21190: Diff 36709.Nov 27 2022, 20:24
teamcity added a comment.Nov 27 2022, 20:24
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

wallet_createwallet.py                    | ✓ Passed  | 2 s
wallet_createwallet.py --descriptors      | ✓ Passed  | 2 s
wallet_createwallet.py --usecli           | ✓ Passed  | 2 s
wallet_descriptor.py                      | ✓ Passed  | 6 s
wallet_disable.py                         | ✓ Passed  | 1 s
wallet_dump.py                            | ✓ Passed  | 4 s
wallet_encryption.py                      | ✓ Passed  | 5 s
wallet_encryption.py --descriptors        | ✓ Passed  | 5 s
wallet_groups.py                          | ✓ Passed  | 14 s
wallet_hd.py                              | ✓ Passed  | 7 s
wallet_hd.py --descriptors                | ✓ Passed  | 5 s
wallet_import_rescan.py                   | ✓ Passed  | 7 s
wallet_import_with_label.py               | ✓ Passed  | 1 s
wallet_importdescriptors.py               | ✓ Passed  | 6 s
wallet_importmulti.py                     | ✓ Passed  | 3 s
wallet_importprunedfunds.py               | ✓ Passed  | 2 s
wallet_importprunedfunds.py --descriptors | ✓ Passed  | 2 s
wallet_keypool.py                         | ✓ Passed  | 3 s
wallet_keypool_topup.py                   | ✓ Passed  | 4 s
wallet_keypool_topup.py --descriptors     | ✓ Passed  | 5 s
wallet_labels.py                          | ✓ Passed  | 2 s
wallet_labels.py --descriptors            | ✓ Passed  | 1 s
wallet_listreceivedby.py                  | ✓ Passed  | 5 s
wallet_listsinceblock.py                  | ✓ Passed  | 4 s
wallet_listsinceblock.py --descriptors    | ✓ Passed  | 8 s
wallet_listtransactions.py                | ✓ Passed  | 5 s
wallet_listtransactions.py --descriptors  | ✓ Passed  | 4 s
wallet_multiwallet.py                     | ✓ Passed  | 40 s
wallet_multiwallet.py --usecli            | ✓ Passed  | 10 s
wallet_reorgsrestore.py                   | ✓ Passed  | 3 s
wallet_resendwallettransactions.py        | ✓ Passed  | 2 s
wallet_send.py                            | ✓ Passed  | 7 s
wallet_startup.py                         | ✓ Passed  | 2 s
wallet_txn_clone.py                       | ✓ Passed  | 1 s
wallet_txn_clone.py --mineblock           | ✓ Passed  | 3 s
wallet_txn_doublespend.py                 | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock     | ✓ Passed  | 3 s
wallet_watchonly.py                       | ✓ Passed  | 1 s
wallet_watchonly.py --usecli              | ✓ Passed  | 2 s

ALL                                       | ✓ Passed  | 1213 s (accumulated) 
Runtime: 243 s

[182/479] Running avalanche test suite
PASSED: avalanche test suite
[201/479] Running pow test suite
PASSED: pow test suite
[214/479] Running seeder test suite
PASSED: seeder test suite
[218/479] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:540:22: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  540 | BOOST_AUTO_TEST_CASE(script_build) {
      |                      ^~~~~~~~~~~~
[226/479] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
tobias_ruck updated this revision to Diff 36710.Nov 27 2022, 21:22

Fix cpp tests

Harbormaster completed remote builds in B21191: Diff 36710.Nov 27 2022, 21:33
tobias_ruck updated this revision to Diff 36711.Nov 27 2022, 22:18

Reorder imports

Harbormaster completed remote builds in B21192: Diff 36711.Nov 27 2022, 22:28
tobias_ruck added inline comments.Nov 28 2022, 07:57
chronik/chronik-cpp/chronik_util.h
16 ↗(On Diff #36711)

Somehow the linter didn't pick up the missing } // namespace chronik

Fabien requested changes to this revision.Nov 28 2022, 08:39

I don't think you need to add a chronik_ prefix to every source file, you'd better create a util/ directory (and eventually a chronik::util:: namespace). Also this will avoid confusion with the chronik-util crate

chronik/chronik-cpp/chronik_util.h
16 ↗(On Diff #36711)

Clang-format doesn't add it for namespaces with 0 or 1 inner line (brackets excepted).
But you can add it manually :)

This revision now requires changes to proceed.Nov 28 2022, 08:39
tobias_ruck updated this revision to Diff 38173.Mar 1 2023, 10:09

Move chronik_util.* to util/hash.* and move HashToArray to namespace chronik::util

tobias_ruck retitled this revision from [Chronik] Move `HashToArray` to chronik_util.cpp/h to [Chronik] Move `HashToArray` to util/hash.cpp/h.Mar 1 2023, 10:14
tobias_ruck edited the test plan for this revision. (Show Details)
tobias_ruck updated this revision to Diff 38174.Mar 1 2023, 10:20

Fix other namespace for HashToArray in chronikbridge_tests.cpp as well

Harbormaster completed remote builds in B22167: Diff 38173.Mar 1 2023, 10:29
teamcity added a comment.Mar 1 2023, 10:29
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

wallet_disable.py                         | ✓ Passed  | 1 s
wallet_dump.py                            | ✓ Passed  | 4 s
wallet_encryption.py                      | ✓ Passed  | 5 s
wallet_encryption.py --descriptors        | ✓ Passed  | 5 s
wallet_groups.py                          | ✓ Passed  | 14 s
wallet_hd.py                              | ✓ Passed  | 6 s
wallet_hd.py --descriptors                | ✓ Passed  | 5 s
wallet_import_rescan.py                   | ✓ Passed  | 7 s
wallet_import_with_label.py               | ✓ Passed  | 1 s
wallet_importdescriptors.py               | ✓ Passed  | 5 s
wallet_importmulti.py                     | ✓ Passed  | 3 s
wallet_importprunedfunds.py               | ✓ Passed  | 2 s
wallet_importprunedfunds.py --descriptors | ✓ Passed  | 2 s
wallet_keypool.py                         | ✓ Passed  | 3 s
wallet_keypool_topup.py                   | ✓ Passed  | 4 s
wallet_keypool_topup.py --descriptors     | ✓ Passed  | 4 s
wallet_labels.py                          | ✓ Passed  | 4 s
wallet_labels.py --descriptors            | ✓ Passed  | 4 s
wallet_listreceivedby.py                  | ✓ Passed  | 6 s
wallet_listsinceblock.py                  | ✓ Passed  | 5 s
wallet_listsinceblock.py --descriptors    | ✓ Passed  | 7 s
wallet_listtransactions.py                | ✓ Passed  | 4 s
wallet_listtransactions.py --descriptors  | ✓ Passed  | 3 s
wallet_multiwallet.py                     | ✓ Passed  | 10 s
wallet_multiwallet.py --usecli            | ✓ Passed  | 9 s
wallet_reorgsrestore.py                   | ✓ Passed  | 3 s
wallet_resendwallettransactions.py        | ✓ Passed  | 2 s
wallet_send.py                            | ✓ Passed  | 7 s
wallet_startup.py                         | ✓ Passed  | 2 s
wallet_timelock.py                        | ✓ Passed  | 1 s
wallet_txn_clone.py                       | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock           | ✓ Passed  | 3 s
wallet_txn_doublespend.py                 | ✓ Passed  | 3 s
wallet_txn_doublespend.py --mineblock     | ✓ Passed  | 3 s
wallet_watchonly.py                       | ✓ Passed  | 2 s
wallet_watchonly.py --usecli              | ✓ Passed  | 2 s
interface_usdt_net.py                     | ○ Skipped | 0 s
interface_usdt_utxocache.py               | ○ Skipped | 0 s
interface_usdt_validation.py              | ○ Skipped | 0 s

ALL                                       | ✓ Passed  | 1235 s (accumulated) 
Runtime: 251 s

[184/483] Running avalanche test suite
PASSED: avalanche test suite
[203/483] Running pow test suite
PASSED: pow test suite
[217/483] Running seeder test suite
PASSED: seeder test suite
[220/483] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:540:22: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  540 | BOOST_AUTO_TEST_CASE(script_build) {
      |                      ^~~~~~~~~~~~
[228/483] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
Harbormaster completed remote builds in B22168: Diff 38174.Mar 1 2023, 10:38
Fabien requested changes to this revision.Mar 1 2023, 11:03

test is broken, back to your queue

This revision now requires changes to proceed.Mar 1 2023, 11:03
tobias_ruck requested review of this revision.Mar 1 2023, 11:56

latest tests are fixed

Fabien accepted this revision.Mar 1 2023, 12:36
This revision is now accepted and ready to land.Mar 1 2023, 12:36
Closed by commit rABCac03125b394b: [Chronik] Move `HashToArray` to util/hash.cpp/h (authored by tobias_ruck). · Explain WhyMar 1 2023, 14:01
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCac03125b394b: [Chronik] Move `HashToArray` to util/hash.cpp/h.

Revision Contents
Changeset List

PathSize
chronik/
1 line
chronik-cpp/
2 lines
9 lines
18 lines
17 lines

Diff 36707

View Options

chronik/CMakeLists.txt

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.h

Loading...
View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/chronik-cpp/chronik_util.h

Loading...
View Options

chronik/chronik-cpp/chronik_util.cpp

Loading...